content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc - Issue 95153002: Make touch-based synthetic gesture take touch slop into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc

Issue 95153002: Make touch-based synthetic gesture take touch slop into account. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unused variable. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h ('k') | content/common/android/view_configuration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc

diff --git a/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc b/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc

index 84d4a1812aa70690ae8d77c69f3dc7e190fd01a1..37a80b3f64447ff48134a71b056e7ee47eba8f8b 100644

--- a/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc

+++ b/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc

@@ -50,10 +50,14 @@ void SyntheticSmoothScrollGesture::ForwardTouchInputEvents(

switch (state_) {

case STARTED:

// Check for an early finish.

- if (HasScrolledEntireDistance()) {

+ if (params_.distance == 0) {

state_ = DONE;

break;

}

+ if (params_.distance > 0)

+ params_.distance += target->GetTouchSlopInDips();

+ else

+ params_.distance -= target->GetTouchSlopInDips();

touch_event_.PressPoint(params_.anchor.x(), current_y_);

ForwardTouchEvent(target);

state_ = MOVING;