Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc

Issue 95153002: Make touch-based synthetic gesture take touch slop into account. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: undo pinch refactoring; get device scale factor from gfx::Screen Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
diff --git a/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
index baefa695d1338af6557bd5b28f498b5aee0b23ac..7118e5120d95f19e19ac39eda9f86089557eb538 100644
--- a/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
+++ b/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
@@ -25,6 +25,7 @@ namespace {
const int kFlushInputRateInMs = 16;
const int kPointerAssumedStoppedTimeMs = 43;
+const int kTouchSlopInDips = 7;
class MockSyntheticGesture : public SyntheticGesture {
public:
@@ -100,6 +101,10 @@ class MockSyntheticGestureTarget : public SyntheticGestureTarget {
pointer_assumed_stopped_time_ms_ = time_ms;
}
+ virtual int GetTouchSlopInDips() const OVERRIDE {
+ return kTouchSlopInDips;
+ }
+
int num_success() const { return num_success_; }
int num_failure() const { return num_failure_; }
@@ -373,7 +378,7 @@ TEST_F(SyntheticGestureControllerTest, SmoothScrollGestureTouch) {
EXPECT_EQ(1, target_->num_success());
EXPECT_EQ(0, target_->num_failure());
- EXPECT_FLOAT_EQ(params.distance,
+ EXPECT_FLOAT_EQ(params.distance + target_->GetTouchSlopInDips(),
static_cast<MockSyntheticSmoothScrollTouchTarget*>(target_)
->scroll_distance());
}
@@ -397,7 +402,7 @@ TEST_F(SyntheticGestureControllerTest, SmoothScrollGestureTouchLongStop) {
EXPECT_EQ(1, target_->num_success());
EXPECT_EQ(0, target_->num_failure());
- EXPECT_FLOAT_EQ(params.distance,
+ EXPECT_FLOAT_EQ(params.distance + target_->GetTouchSlopInDips(),
static_cast<MockSyntheticSmoothScrollTouchTarget*>(target_)
->scroll_distance());
EXPECT_GE(GetTotalTime(), target_->PointerAssumedStoppedTime());
@@ -439,9 +444,10 @@ TEST_F(SyntheticGestureControllerTest, PinchGestureTouchZoomIn) {
EXPECT_EQ(
static_cast<MockSyntheticPinchTouchTarget*>(target_)->zoom_direction(),
MockSyntheticPinchTouchTarget::ZOOM_IN);
- EXPECT_FLOAT_EQ(params.total_num_pixels_covered,
- static_cast<MockSyntheticPinchTouchTarget*>(target_)
- ->total_num_pixels_covered());
+ EXPECT_FLOAT_EQ(
+ params.total_num_pixels_covered + 2 * target_->GetTouchSlopInDips(),
+ static_cast<MockSyntheticPinchTouchTarget*>(target_)
+ ->total_num_pixels_covered());
}
TEST_F(SyntheticGestureControllerTest, PinchGestureTouchZoomOut) {
@@ -461,9 +467,10 @@ TEST_F(SyntheticGestureControllerTest, PinchGestureTouchZoomOut) {
EXPECT_EQ(
static_cast<MockSyntheticPinchTouchTarget*>(target_)->zoom_direction(),
MockSyntheticPinchTouchTarget::ZOOM_OUT);
- EXPECT_FLOAT_EQ(params.total_num_pixels_covered,
- static_cast<MockSyntheticPinchTouchTarget*>(target_)
- ->total_num_pixels_covered());
+ EXPECT_FLOAT_EQ(
+ params.total_num_pixels_covered + 2 * target_->GetTouchSlopInDips(),
+ static_cast<MockSyntheticPinchTouchTarget*>(target_)
+ ->total_num_pixels_covered());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698