Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 951483002: Make SkNewImageFromBitmap take pixel ref origin into account (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@skimage-filters-01-deferred-canvas-writepixels-skip
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkNewImageFromBitmap take pixel ref origin into account Make SkNewImageFromBitmap take pixel ref origin into account. BUG=skia:3388 Committed: https://skia.googlesource.com/skia/+/73953e7d00f0a75a98e985ceed88059d35945327

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -45 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/image/SkImagePriv.h View 1 chunk +3 lines, -1 line 0 comments Download
D src/image/SkImagePriv.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 4 chunks +34 lines, -7 lines 0 comments Download
A tests/SkImageTest.cpp View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
5 years, 10 months ago (2015-02-23 14:26:45 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-23 22:56:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951483002/20001
5 years, 10 months ago (2015-02-24 06:06:40 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 06:12:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/73953e7d00f0a75a98e985ceed88059d35945327

Powered by Google App Engine
This is Rietveld 408576698