Chromium Code Reviews| Index: base/trace_event/process_memory_maps_dump_provider_unittest.cc |
| diff --git a/base/trace_event/process_memory_maps_dump_provider_unittest.cc b/base/trace_event/process_memory_maps_dump_provider_unittest.cc |
| index 33c1bbb0f25c2804cb4714ff3a31e376a9596af8..5f291af9736d12fe0e7728ef9ad8d270f45849ff 100644 |
| --- a/base/trace_event/process_memory_maps_dump_provider_unittest.cc |
| +++ b/base/trace_event/process_memory_maps_dump_provider_unittest.cc |
| @@ -12,11 +12,69 @@ |
| #include "base/trace_event/trace_event_argument.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| +namespace { |
| +const char kTestSmaps1[] = |
| + "00400000-004be000 r-xp 00000000 fc:01 1234 /file/1\n" |
| + "Size: 760 kB\n" |
| + "Rss: 296 kB\n" |
| + "Pss: 162 kB\n" |
| + "Shared_Clean: 228 kB\n" |
| + "Shared_Dirty: 0 kB\n" |
| + "Private_Clean: 0 kB\n" |
| + "Private_Dirty: 68 kB\n" |
| + "Referenced: 296 kB\n" |
| + "Anonymous: 68 kB\n" |
| + "AnonHugePages: 0 kB\n" |
| + "Swap: 0 kB\n" |
| + "KernelPageSize: 4 kB\n" |
| + "MMUPageSize: 4 kB\n" |
| + "Locked: 0 kB\n" |
| + "VmFlags: rd ex mr mw me dw sd\n" |
| + "ff000000-ff800000 -w-p 00001080 fc:01 0 /file/name with space\n" |
| + "Size: 0 kB\n" |
| + "Rss: 128 kB\n" |
| + "Pss: 128 kB\n" |
| + "Shared_Clean: 124 kB\n" |
| + "Shared_Dirty: 0 kB\n" |
| + "Private_Clean: 68 kB\n" |
| + "Private_Dirty: 0 kB\n" |
| + "Referenced: 296 kB\n" |
| + "Anonymous: 0 kB\n" |
| + "AnonHugePages: 0 kB\n" |
| + "Swap: 0 kB\n" |
| + "KernelPageSize: 4 kB\n" |
| + "MMUPageSize: 4 kB\n" |
| + "Locked: 0 kB\n" |
| + "VmFlags: rd ex mr mw me dw sd"; |
| + |
| +const char kTestSmaps2[] = |
| + "7fe7ce79c000-7fe7ce7a8000 ---p 00000000 00:00 0 \n" // An anonymous vma. |
| + "Size: 48 kB\n" |
| + "Rss: 40 kB\n" |
| + "Pss: 0 kB\n" |
| + "Shared_Clean: 16 kB\n" |
| + "Shared_Dirty: 12 kB\n" |
| + "Private_Clean: 8 kB\n" |
| + "Private_Dirty: 4 kB\n" |
| + "Referenced: 40 kB\n" |
| + "Anonymous: 16 kB\n" |
| + "AnonHugePages: 0 kB\n" |
| + "Swap: 0 kB\n" |
| + "KernelPageSize: 4 kB\n" |
| + "MMUPageSize: 4 kB\n" |
| + "Locked: 0 kB\n" |
| + "VmFlags: rd wr mr mw me ac sd"; |
| +} // namespace |
|
Sami
2015/02/24 11:11:25
Could you add a couple of malformed examples (empt
Primiano Tucci (use gerrit)
2015/02/24 13:17:07
Done for negative zero. Empty file, instead, is a
|
| + |
| namespace base { |
| namespace trace_event { |
| #if defined(OS_LINUX) || defined(OS_ANDROID) |
| TEST(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps) { |
| + const uint32 kProtR = ProcessMemoryMaps::VMRegion::kProtectionFlagsRead; |
| + const uint32 kProtW = ProcessMemoryMaps::VMRegion::kProtectionFlagsWrite; |
| + const uint32 kProtX = ProcessMemoryMaps::VMRegion::kProtectionFlagsExec; |
| + |
| auto pmmdp = ProcessMemoryMapsDumpProvider::GetInstance(); |
| // Emulate a non-existent /proc/self/smaps. |
| @@ -34,8 +92,46 @@ TEST(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps) { |
| pmmdp->DumpInto(&pmd_invalid); |
| ASSERT_FALSE(pmd_invalid.has_process_mmaps()); |
| - // TODO(primiano): in the next CLs add the code to parse some actual smaps |
| - // files and check that the parsing logic of the dump provider holds. |
| + // Parse the 1st smaps file. |
| + ProcessMemoryDump pmd_1; |
| + std::istringstream test_smaps_1(kTestSmaps1); |
| + ProcessMemoryMapsDumpProvider::proc_smaps_for_testing = &test_smaps_1; |
| + pmmdp->DumpInto(&pmd_1); |
| + ASSERT_TRUE(pmd_1.has_process_mmaps()); |
| + const auto& regions_1 = pmd_1.process_mmaps()->vm_regions(); |
| + ASSERT_EQ(2UL, regions_1.size()); |
| + |
| + EXPECT_EQ(0x00400000UL, regions_1[0].start_address); |
| + EXPECT_EQ(0x004be000UL - 0x00400000UL, regions_1[0].size_in_bytes); |
| + EXPECT_EQ(kProtR | kProtX, regions_1[0].protection_flags); |
| + EXPECT_EQ("/file/1", regions_1[0].mapped_file); |
| + EXPECT_EQ(0UL, regions_1[0].mapped_file_offset); |
| + EXPECT_EQ(296 * 1024UL, regions_1[0].byte_stats_resident); |
| + EXPECT_EQ(68 * 1024UL, regions_1[0].byte_stats_anonymous); |
| + |
| + EXPECT_EQ(0xff000000UL, regions_1[1].start_address); |
| + EXPECT_EQ(0xff800000UL - 0xff000000UL, regions_1[1].size_in_bytes); |
| + EXPECT_EQ(kProtW, regions_1[1].protection_flags); |
| + EXPECT_EQ("/file/name with space", regions_1[1].mapped_file); |
| + EXPECT_EQ(0x00001080UL, regions_1[1].mapped_file_offset); |
| + EXPECT_EQ(128 * 1024UL, regions_1[1].byte_stats_resident); |
| + EXPECT_EQ(0UL, regions_1[1].byte_stats_anonymous); |
| + |
| + // Parse the 2nd smaps file. |
| + ProcessMemoryDump pmd_2; |
| + std::istringstream test_smaps_2(kTestSmaps2); |
| + ProcessMemoryMapsDumpProvider::proc_smaps_for_testing = &test_smaps_2; |
| + pmmdp->DumpInto(&pmd_2); |
| + ASSERT_TRUE(pmd_2.has_process_mmaps()); |
| + const auto& regions_2 = pmd_2.process_mmaps()->vm_regions(); |
| + ASSERT_EQ(1UL, regions_2.size()); |
| + EXPECT_EQ(0x7fe7ce79c000UL, regions_2[0].start_address); |
| + EXPECT_EQ(0x7fe7ce7a8000UL - 0x7fe7ce79c000UL, regions_2[0].size_in_bytes); |
| + EXPECT_EQ(0U, regions_2[0].protection_flags); |
| + EXPECT_EQ("", regions_2[0].mapped_file); |
| + EXPECT_EQ(0UL, regions_2[0].mapped_file_offset); |
| + EXPECT_EQ(40 * 1024UL, regions_2[0].byte_stats_resident); |
| + EXPECT_EQ(16 * 1024UL, regions_2[0].byte_stats_anonymous); |
| } |
| #endif // defined(OS_LINUX) || defined(OS_ANDROID) |