MacViews: Handle Tab properly

MacViews: Handle Tab properly

On Mac, interpreting a tab keypress into an action message calls
[NSResponder insertTab]. [RenderWidgetHostViewCocoa
doCommandBySelector:] has for a long time had a check that skips
converting any action message whose selector starts with "insert" into
an editing command, and just treats it as a regular keypress instead.

This approach also works well for UI in MacViews, so do the same.

Theoretically a user could remap a different key or key combination to
the 'insertTab' action message, but that's unlikely.

Updates TextfieldTest.FocusTraversalTest with cross-platform checks to
test for this case. Also tested manually with views_examples.

For the test to work with the approach in this CL, the event simulator
needs to provide an answer for -[NSApplication currentEvent], so that's
done too.

BUG=454353
Committed: https://crrev.com/f8a2ca3720d41d2bf03b2e68f483d5edd28d8af6
Cr-Commit-Position: refs/heads/master@{#318172}

[tapted, 2015-02-24 06:28:10]

tapted@chromium.org changed reviewers:
+ andresantoso@chromium.org

[tapted, 2015-02-24 06:40:15]

Hi Andre, please take a look

[Andre, 2015-02-24 16:57:58]

LGTM

[tapted, 2015-02-25 10:55:39]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2015-02-25 10:55:39]

+sky for OWNERS in ui/views - PTAL

[sky, 2015-02-25 17:01:02]

LGTM

[tapted, 2015-02-26 00:46:34]

andre: ptal

https://codereview.chromium.org/951433002/diff/40001/ui/views/cocoa/bridged_c...
File ui/views/cocoa/bridged_content_view.mm (right):

https://codereview.chromium.org/951433002/diff/40001/ui/views/cocoa/bridged_c...
ui/views/cocoa/bridged_content_view.mm:359: - (void)insertText:(id)text {
Ah, my macviews trybot picked up a regression here in interactive_ui_tests (menu
mnemonic stuff) . Turns out insertText: is still needed because NSResponder's
interpretKeyEvents:implementation doesn't direct insertText: through
doCommandBySelector:, so the insertText: method is still needed (as well as
insertText:replacementRange:)

I've restored the old method and added a comment for the unwary.

[Andre, 2015-02-26 00:56:44]

LGTM

[tapted, 2015-02-26 01:33:58]

The CQ bit was checked by tapted@chromium.org

[tapted, 2015-02-26 01:33:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/951433002/#ps40001 (title:
"Still need insertTexT:")

[commit-bot: I haz the power, 2015-02-26 01:35:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951433002/40001

[commit-bot: I haz the power, 2015-02-26 01:44:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-26 01:45:17]

Patchset 3 (id:??) landed as
https://crrev.com/f8a2ca3720d41d2bf03b2e68f483d5edd28d8af6
Cr-Commit-Position: refs/heads/master@{#318172}