Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 951353003: Allow to exlude jar in android_standalone_library. (Closed)

Created:
5 years, 10 months ago by qsr
Modified:
5 years, 10 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow to exlude jar in android_standalone_library. R=cjhopman@chromium.org Committed: https://crrev.com/cd6ee6d5ce5a42c50d0284daeaa7bd664f58b8fb Cr-Commit-Position: refs/heads/master@{#318214}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Follow review #

Patch Set 3 : Rebase path before passing it to external command. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M build/android/gyp/dex.py View 1 2 chunks +6 lines, -7 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
qsr
5 years, 10 months ago (2015-02-24 14:14:00 UTC) #1
cjhopman
https://codereview.chromium.org/951353003/diff/1/build/android/gyp/dex.py File build/android/gyp/dex.py (right): https://codereview.chromium.org/951353003/diff/1/build/android/gyp/dex.py#newcode53 build/android/gyp/dex.py:53: parser.add_option('--excluded-paths-file', You could change this to instead just take ...
5 years, 10 months ago (2015-02-24 21:23:04 UTC) #2
qsr
On 2015/02/24 21:23:04, cjhopman wrote: > https://codereview.chromium.org/951353003/diff/1/build/android/gyp/dex.py > File build/android/gyp/dex.py (right): > > https://codereview.chromium.org/951353003/diff/1/build/android/gyp/dex.py#newcode53 > ...
5 years, 10 months ago (2015-02-25 16:26:19 UTC) #3
qsr
Thanks for the explanation -> Update dex.py to take a list, and used FileArg for ...
5 years, 10 months ago (2015-02-25 18:29:47 UTC) #4
cjhopman
lgtm
5 years, 10 months ago (2015-02-25 18:33:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951353003/40001
5 years, 10 months ago (2015-02-26 10:00:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 10:53:02 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 10:53:57 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd6ee6d5ce5a42c50d0284daeaa7bd664f58b8fb
Cr-Commit-Position: refs/heads/master@{#318214}

Powered by Google App Engine
This is Rietveld 408576698