Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 95133002: Add an extension bubble explaining which extensions are in dev mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync'ed Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6
7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
11 #include "chrome/browser/extensions/extension_action_manager.h"
12 #include "chrome/browser/extensions/extension_prefs.h"
13 #include "chrome/browser/extensions/extension_service.h"
14 #include "chrome/browser/extensions/extension_system.h"
15 #include "chrome/browser/extensions/suspicious_extension_bubble_controller.h"
16 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/views/frame/browser_view.h"
19 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
20 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
21 #include "grit/locale_settings.h"
22 #include "ui/base/accessibility/accessible_view_state.h"
23 #include "ui/base/resource/resource_bundle.h"
24 #include "ui/views/controls/button/label_button.h"
25 #include "ui/views/controls/label.h"
26 #include "ui/views/controls/link.h"
27 #include "ui/views/layout/grid_layout.h"
28 #include "ui/views/view.h"
29 #include "ui/views/widget/widget.h"
30
31 namespace {
32
33 // Layout constants.
34 const int kExtensionListPadding = 10;
35 const int kInsetBottomRight = 13;
36 const int kInsetLeft = 14;
37 const int kInsetTop = 9;
38 const int kHeadlineMessagePadding = 4;
39 const int kHeadlineRowPadding = 10;
40 const int kMessageBubblePadding = 11;
41
42 // How many extensions to show in the bubble (max).
43 const size_t kMaxExtensionsToShow = 7;
44
45 // How long to wait until showing the bubble (in seconds).
46 const int kBubbleAppearanceWaitTime = 5;
47
48 } // namespace
49
50 ////////////////////////////////////////////////////////////////////////////////
51 // ExtensionMessageBubbleView
52
53 namespace extensions {
54
55 ExtensionMessageBubbleView::ExtensionMessageBubbleView(
56 views::View* anchor_view,
57 ExtensionMessageBubbleController* controller)
58 : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
59 weak_factory_(this),
60 controller_(controller),
61 headline_(NULL),
62 learn_more_(NULL),
63 dismiss_button_(NULL),
64 link_clicked_(false),
65 action_taken_(false) {
66 DCHECK(anchor_view->GetWidget());
67 set_close_on_deactivate(false);
68 set_move_with_anchor(true);
69 set_close_on_esc(true);
70
71 // Compensate for built-in vertical padding in the anchor view's image.
72 set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
73 }
74
75 // static
76 void ExtensionMessageBubbleView::MaybeShow(
77 Browser* browser,
78 views::View* anchor_view) {
79 // The list of suspicious extensions takes priority over the dev mode bubble,
80 // since that needs to be shown as soon as we disable something. The dev mode
81 // bubble is not as time sensitive so we'll catch the dev mode extensions on
82 // the next startup. That way, we're not too spammy with the bubbles.
83 SuspiciousExtensionBubbleController* suspicious_extensions =
84 extensions::SuspiciousExtensionBubbleController::Get(
85 browser->profile());
86 if (suspicious_extensions->HasExtensionList()) {
87 ExtensionMessageBubbleView* bubble_delegate =
88 new ExtensionMessageBubbleView(anchor_view, suspicious_extensions);
89 views::BubbleDelegateView::CreateBubble(bubble_delegate);
90 suspicious_extensions->Show(bubble_delegate);
91 return;
92 }
93
94 DevModeBubbleController* dev_mode_extensions =
95 extensions::DevModeBubbleController::Get(
96 browser->profile());
97 if (dev_mode_extensions->HasExtensionList()) {
98 // Find an extension browser action view to anchor against in the toolbar.
99 BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
100 views::View* reference_view = NULL;
101 BrowserActionsContainer* container =
102 browser_view->GetToolbarView()->browser_actions();
103 if (container->animating())
104 return;
105
106 ExtensionService* service = extensions::ExtensionSystem::Get(
107 browser->profile())->extension_service();
108 extensions::ExtensionActionManager* extension_action_manager =
109 extensions::ExtensionActionManager::Get(browser->profile());
110
111 const ExtensionIdList extension_list =
112 dev_mode_extensions->extension_id_list();
113 for (size_t i = 0; i < extension_list.size(); ++i) {
114 const Extension* extension =
115 service->GetExtensionById(extension_list[i], false);
116 if (!extension)
117 continue;
118 reference_view = container->GetBrowserActionView(
119 extension_action_manager->GetBrowserAction(*extension));
120 if (reference_view && reference_view->visible())
121 break; // Found a good candidate.
122 }
123 if (reference_view) {
124 // If we have a view, it means we found a browser action and we want to
125 // point to the chevron, not the hotdog menu.
126 if (!reference_view->visible())
127 reference_view = container->chevron(); // It's hidden, use the chevron.
128 }
129 if (reference_view && reference_view->visible())
130 anchor_view = reference_view; // Catch-all is the hotdog menu.
131
132 // Show the bubble.
133 ExtensionMessageBubbleView* bubble_delegate =
134 new ExtensionMessageBubbleView(anchor_view, dev_mode_extensions);
135 views::BubbleDelegateView::CreateBubble(bubble_delegate);
136 dev_mode_extensions->Show(bubble_delegate);
137 }
138 }
139
140 void ExtensionMessageBubbleView::OnActionButtonClicked(
141 const base::Closure& callback) {
142 action_callback_ = callback;
143 }
144
145 void ExtensionMessageBubbleView::OnDismissButtonClicked(
146 const base::Closure& callback) {
147 dismiss_callback_ = callback;
148 }
149
150 void ExtensionMessageBubbleView::OnLinkClicked(
151 const base::Closure& callback) {
152 link_callback_ = callback;
153 }
154
155 void ExtensionMessageBubbleView::Show() {
156 // Not showing the bubble right away (during startup) has a few benefits:
157 // We don't have to worry about focus being lost due to the Omnibox (or to
158 // other things that want focus at startup). This allows Esc to work to close
159 // the bubble and also solves the keyboard accessibility problem that comes
160 // with focus being lost (we don't have a good generic mechanism of injecting
161 // bubbles into the focus cycle). Another benefit of delaying the show is
162 // that fade-in works (the fade-in isn't apparent if the the bubble appears at
163 // startup).
164 base::MessageLoop::current()->PostDelayedTask(
165 FROM_HERE,
166 base::Bind(&ExtensionMessageBubbleView::ShowBubble,
167 weak_factory_.GetWeakPtr()),
168 base::TimeDelta::FromSeconds(kBubbleAppearanceWaitTime));
169 }
170
171 void ExtensionMessageBubbleView::OnWidgetDestroying(views::Widget* widget) {
172 // To catch Esc, we monitor destroy message. Unless the link has been clicked,
173 // we assume Dismiss was the action taken.
174 if (!link_clicked_ && !action_taken_)
175 dismiss_callback_.Run();
176 }
177
178 ////////////////////////////////////////////////////////////////////////////////
179 // ExtensionMessageBubbleView - private.
180
181 ExtensionMessageBubbleView::~ExtensionMessageBubbleView() {
182 }
183
184 void ExtensionMessageBubbleView::ShowBubble() {
185 StartFade(true);
186 }
187
188 void ExtensionMessageBubbleView::Init() {
189 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
190
191 views::GridLayout* layout = views::GridLayout::CreatePanel(this);
192 layout->SetInsets(kInsetTop, kInsetLeft,
193 kInsetBottomRight, kInsetBottomRight);
194 SetLayoutManager(layout);
195
196 const int headline_column_set_id = 0;
197 views::ColumnSet* top_columns = layout->AddColumnSet(headline_column_set_id);
198 top_columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER,
199 0, views::GridLayout::USE_PREF, 0, 0);
200 top_columns->AddPaddingColumn(1, 0);
201 layout->StartRow(0, headline_column_set_id);
202
203 headline_ = new views::Label();
204 headline_->SetFont(rb.GetFont(ui::ResourceBundle::MediumFont));
205 headline_->SetText(controller_->GetTitle());
206 layout->AddView(headline_);
207
208 layout->AddPaddingRow(0, kHeadlineRowPadding);
209
210 const int text_column_set_id = 1;
211 views::ColumnSet* upper_columns = layout->AddColumnSet(text_column_set_id);
212 upper_columns->AddColumn(
213 views::GridLayout::LEADING, views::GridLayout::LEADING,
214 0, views::GridLayout::USE_PREF, 0, 0);
215 layout->StartRow(0, text_column_set_id);
216
217 views::Label* message = new views::Label();
218 message->SetMultiLine(true);
219 message->SetHorizontalAlignment(gfx::ALIGN_LEFT);
220 message->SetText(controller_->GetMessageBody());
221 message->SizeToFit(views::Widget::GetLocalizedContentsWidth(
222 IDS_EXTENSION_WIPEOUT_BUBBLE_WIDTH_CHARS));
223 layout->AddView(message);
224
225 if (controller_->ShouldShowExtensionList()) {
226 const int extension_list_column_set_id = 2;
227 views::ColumnSet* middle_columns =
228 layout->AddColumnSet(extension_list_column_set_id);
229 middle_columns->AddPaddingColumn(0, kExtensionListPadding);
230 middle_columns->AddColumn(
231 views::GridLayout::LEADING, views::GridLayout::CENTER,
232 0, views::GridLayout::USE_PREF, 0, 0);
233
234 layout->StartRowWithPadding(0, extension_list_column_set_id,
235 0, kHeadlineMessagePadding);
236 views::Label* extensions = new views::Label();
237 extensions->SetMultiLine(true);
238 extensions->SetHorizontalAlignment(gfx::ALIGN_LEFT);
239
240 std::vector<string16> extension_list;
241 char16 bullet_point = 0x2022;
242
243 std::vector<string16> suspicious = controller_->GetExtensionList();
244 size_t i = 0;
245 for (; i < suspicious.size() && i < kMaxExtensionsToShow; ++i) {
246 // Add each extension with bullet point.
247 extension_list.push_back(
248 bullet_point + ASCIIToUTF16(" ") + suspicious[i]);
249 }
250
251 if (i > kMaxExtensionsToShow) {
252 string16 difference = base::IntToString16(i - kMaxExtensionsToShow);
253 extension_list.push_back(bullet_point + ASCIIToUTF16(" ") +
254 controller_->GetOverflowText(difference));
255 }
256
257 extensions->SetText(JoinString(extension_list, ASCIIToUTF16("\n")));
258 extensions->SizeToFit(views::Widget::GetLocalizedContentsWidth(
259 IDS_EXTENSION_WIPEOUT_BUBBLE_WIDTH_CHARS));
260 layout->AddView(extensions);
261 }
262
263 string16 action_button = controller_->GetActionButtonLabel();
264
265 const int action_row_column_set_id = 3;
266 views::ColumnSet* bottom_columns =
267 layout->AddColumnSet(action_row_column_set_id);
268 bottom_columns->AddColumn(views::GridLayout::LEADING,
269 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
270 bottom_columns->AddPaddingColumn(1, 0);
271 bottom_columns->AddColumn(views::GridLayout::TRAILING,
272 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
273 if (!action_button.empty()) {
274 bottom_columns->AddColumn(views::GridLayout::TRAILING,
275 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
276 }
277 layout->StartRowWithPadding(0, action_row_column_set_id,
278 0, kMessageBubblePadding);
279
280 learn_more_ = new views::Link(controller_->GetLearnMoreLabel());
281 learn_more_->set_listener(this);
282 layout->AddView(learn_more_);
283
284 if (!action_button.empty()) {
285 action_button_ = new views::LabelButton(this, action_button.c_str());
286 action_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
287 layout->AddView(action_button_);
288 }
289
290 dismiss_button_ = new views::LabelButton(this,
291 controller_->GetDismissButtonLabel());
292 dismiss_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
293 layout->AddView(dismiss_button_);
294 }
295
296 void ExtensionMessageBubbleView::ButtonPressed(views::Button* sender,
297 const ui::Event& event) {
298 if (sender == action_button_) {
299 action_taken_ = true;
300 action_callback_.Run();
301 } else {
302 DCHECK_EQ(dismiss_button_, sender);
303 }
304 GetWidget()->Close();
305 }
306
307 void ExtensionMessageBubbleView::LinkClicked(views::Link* source,
308 int event_flags) {
309 DCHECK_EQ(learn_more_, source);
310 link_clicked_ = true;
311 link_callback_.Run();
312 GetWidget()->Close();
313 }
314
315 void ExtensionMessageBubbleView::GetAccessibleState(
316 ui::AccessibleViewState* state) {
317 state->role = ui::AccessibilityTypes::ROLE_ALERT;
318 }
319
320 void ExtensionMessageBubbleView::ViewHierarchyChanged(
321 const ViewHierarchyChangedDetails& details) {
322 if (details.is_add && details.child == this)
323 NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_ALERT, true);
324 }
325
326 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698