Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 95133002: Add an extension bubble explaining which extensions are in dev mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6
7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
11 #include "chrome/browser/extensions/extension_action_manager.h"
12 #include "chrome/browser/extensions/extension_prefs.h"
13 #include "chrome/browser/extensions/extension_service.h"
14 #include "chrome/browser/extensions/extension_system.h"
15 #include "chrome/browser/extensions/suspicious_extension_bubble_controller.h"
16 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/views/frame/browser_view.h"
19 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
20 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
21 #include "grit/locale_settings.h"
22 #include "ui/base/accessibility/accessible_view_state.h"
23 #include "ui/base/resource/resource_bundle.h"
24 #include "ui/views/controls/button/label_button.h"
25 #include "ui/views/controls/label.h"
26 #include "ui/views/controls/link.h"
27 #include "ui/views/layout/grid_layout.h"
28 #include "ui/views/view.h"
29 #include "ui/views/widget/widget.h"
30
31 namespace {
32
33 // Layout constants.
34 const int kExtensionListPadding = 10;
35 const int kInsetBottomRight = 13;
36 const int kInsetLeft = 14;
37 const int kInsetTop = 9;
38 const int kHeadlineMessagePadding = 4;
39 const int kHeadlineRowPadding = 10;
40 const int kMessageBubblePadding = 11;
41
42 // How many extensions to show in the bubble (max).
43 const size_t kMaxExtensionsToShow = 7;
44
45 // How long to wait until showing the bubble (in seconds).
46 const int kBubbleAppearanceWaitTime = 5;
47
48 } // namespace
49
50 ////////////////////////////////////////////////////////////////////////////////
51 // ExtensionMessageBubbleView
52
53 namespace extensions {
54
55 ExtensionMessageBubbleView::ExtensionMessageBubbleView(
56 views::View* anchor_view,
57 ExtensionMessageBubbleController::Delegate* delegate)
58 : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
59 weak_factory_(this),
60 delegate_(delegate),
61 headline_(NULL),
62 learn_more_(NULL),
63 dismiss_button_(NULL),
64 link_clicked_(false),
65 action_taken_(false) {
66 DCHECK(anchor_view->GetWidget());
67 set_close_on_deactivate(false);
68 set_move_with_anchor(true);
69 set_close_on_esc(true);
70
71 // Compensate for built-in vertical padding in the anchor view's image.
72 set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
73 }
74
75 // static
76 void ExtensionMessageBubbleView::MaybeShow(
77 Browser* browser,
78 ToolbarView* toolbar_view,
79 views::View* anchor_view) {
80 // The list of suspicious extensions takes priority over the dev mode bubble,
81 // since that needs to be shown as soon as we disable something. The dev mode
82 // bubble is not as time sensitive so we'll catch the dev mode extensions on
83 // the next startup/next window that opens. That way, we're not too spammy
84 // with the bubbles.
85 SuspiciousExtensionBubbleController* suspicious_extensions =
86 extensions::SuspiciousExtensionBubbleController::Get(
87 browser->profile());
88 if (suspicious_extensions->ShouldShow()) {
89 ExtensionMessageBubbleView* bubble_delegate =
90 new ExtensionMessageBubbleView(anchor_view, suspicious_extensions);
91 views::BubbleDelegateView::CreateBubble(bubble_delegate);
92 suspicious_extensions->Show(bubble_delegate);
93 return;
94 }
95
96 DevModeBubbleController* dev_mode_extensions =
97 extensions::DevModeBubbleController::Get(
98 browser->profile());
99 if (dev_mode_extensions->ShouldShow()) {
100 views::View* reference_view = NULL;
101 BrowserActionsContainer* container = toolbar_view->browser_actions();
102 if (container->animating())
103 return;
104
105 ExtensionService* service = extensions::ExtensionSystem::Get(
106 browser->profile())->extension_service();
107 extensions::ExtensionActionManager* extension_action_manager =
108 extensions::ExtensionActionManager::Get(browser->profile());
109
110 const ExtensionIdList extension_list =
111 dev_mode_extensions->GetExtensionIdList();
112 for (size_t i = 0; i < extension_list.size(); ++i) {
113 const Extension* extension =
114 service->GetExtensionById(extension_list[i], false);
115 if (!extension)
116 continue;
117 reference_view = container->GetBrowserActionView(
118 extension_action_manager->GetBrowserAction(*extension));
119 if (reference_view && reference_view->visible())
120 break; // Found a good candidate.
121 }
122 if (reference_view) {
123 // If we have a view, it means we found a browser action and we want to
124 // point to the chevron, not the hotdog menu.
125 if (!reference_view->visible())
126 reference_view = container->chevron(); // It's hidden, use the chevron.
127 }
128 if (reference_view && reference_view->visible())
129 anchor_view = reference_view; // Catch-all is the hotdog menu.
130
131 // Show the bubble.
132 ExtensionMessageBubbleView* bubble_delegate =
133 new ExtensionMessageBubbleView(anchor_view, dev_mode_extensions);
134 views::BubbleDelegateView::CreateBubble(bubble_delegate);
135 dev_mode_extensions->Show(bubble_delegate);
136 }
137 }
138
139 void ExtensionMessageBubbleView::OnActionButtonClicked(
140 const base::Closure& callback) {
141 action_callback_ = callback;
142 }
143
144 void ExtensionMessageBubbleView::OnDismissButtonClicked(
145 const base::Closure& callback) {
146 dismiss_callback_ = callback;
147 }
148
149 void ExtensionMessageBubbleView::OnLinkClicked(
150 const base::Closure& callback) {
151 link_callback_ = callback;
152 }
153
154 void ExtensionMessageBubbleView::Show() {
155 // Not showing the bubble right away (during startup) has a few benefits:
156 // We don't have to worry about focus being lost due to the Omnibox (or to
157 // other things that want focus at startup). This allows Esc to work to close
158 // the bubble and also solves the keyboard accessibility problem that comes
159 // with focus being lost (we don't have a good generic mechanism of injecting
160 // bubbles into the focus cycle). Another benefit of delaying the show is
161 // that fade-in works (the fade-in isn't apparent if the the bubble appears at
162 // startup).
163 base::MessageLoop::current()->PostDelayedTask(
164 FROM_HERE,
165 base::Bind(&ExtensionMessageBubbleView::ShowBubble,
166 weak_factory_.GetWeakPtr()),
167 base::TimeDelta::FromSeconds(kBubbleAppearanceWaitTime));
168 }
169
170 void ExtensionMessageBubbleView::OnWidgetDestroying(views::Widget* widget) {
171 // To catch Esc, we monitor destroy message. Unless the link has been clicked,
172 // we assume Dismiss was the action taken.
173 if (!link_clicked_ && !action_taken_)
174 dismiss_callback_.Run();
175 }
176
177 ////////////////////////////////////////////////////////////////////////////////
178 // ExtensionMessageBubbleView - private.
179
180 ExtensionMessageBubbleView::~ExtensionMessageBubbleView() {
181 }
182
183 void ExtensionMessageBubbleView::ShowBubble() {
184 StartFade(true);
185 }
186
187 void ExtensionMessageBubbleView::Init() {
188 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
189
190 views::GridLayout* layout = views::GridLayout::CreatePanel(this);
191 layout->SetInsets(kInsetTop, kInsetLeft,
192 kInsetBottomRight, kInsetBottomRight);
193 SetLayoutManager(layout);
194
195 const int headline_column_set_id = 0;
196 views::ColumnSet* top_columns = layout->AddColumnSet(headline_column_set_id);
197 top_columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER,
198 0, views::GridLayout::USE_PREF, 0, 0);
199 top_columns->AddPaddingColumn(1, 0);
200 layout->StartRow(0, headline_column_set_id);
201
202 headline_ = new views::Label();
203 headline_->SetFont(rb.GetFont(ui::ResourceBundle::MediumFont));
204 headline_->SetText(delegate_->GetTitle());
205 layout->AddView(headline_);
206
207 layout->AddPaddingRow(0, kHeadlineRowPadding);
208
209 const int text_column_set_id = 1;
210 views::ColumnSet* upper_columns = layout->AddColumnSet(text_column_set_id);
211 upper_columns->AddColumn(
212 views::GridLayout::LEADING, views::GridLayout::LEADING,
213 0, views::GridLayout::USE_PREF, 0, 0);
214 layout->StartRow(0, text_column_set_id);
215
216 views::Label* message = new views::Label();
217 message->SetMultiLine(true);
218 message->SetHorizontalAlignment(gfx::ALIGN_LEFT);
219 message->SetText(delegate_->GetMessageBody());
220 message->SizeToFit(views::Widget::GetLocalizedContentsWidth(
221 IDS_EXTENSION_WIPEOUT_BUBBLE_WIDTH_CHARS));
222 layout->AddView(message);
223
224 if (delegate_->ShouldShowExtensionList()) {
225 const int extension_list_column_set_id = 2;
226 views::ColumnSet* middle_columns =
227 layout->AddColumnSet(extension_list_column_set_id);
228 middle_columns->AddPaddingColumn(0, kExtensionListPadding);
229 middle_columns->AddColumn(
230 views::GridLayout::LEADING, views::GridLayout::CENTER,
231 0, views::GridLayout::USE_PREF, 0, 0);
232
233 layout->StartRowWithPadding(0, extension_list_column_set_id,
234 0, kHeadlineMessagePadding);
235 views::Label* extensions = new views::Label();
236 extensions->SetMultiLine(true);
237 extensions->SetHorizontalAlignment(gfx::ALIGN_LEFT);
238
239 std::vector<string16> extension_list;
240 char16 bullet_point = 0x2022;
241
242 std::vector<string16> suspicious = delegate_->GetExtensions();
243 size_t i = 0;
244 for (; i < suspicious.size() && i < kMaxExtensionsToShow; ++i) {
245 // Add each extension with bullet point.
246 extension_list.push_back(
247 bullet_point + ASCIIToUTF16(" ") + suspicious[i]);
248 }
249
250 if (i > kMaxExtensionsToShow) {
251 string16 difference = base::IntToString16(i - kMaxExtensionsToShow);
252 extension_list.push_back(bullet_point + ASCIIToUTF16(" ") +
253 delegate_->GetOverflowText(difference));
254 }
255
256 extensions->SetText(JoinString(extension_list, ASCIIToUTF16("\n")));
257 extensions->SizeToFit(views::Widget::GetLocalizedContentsWidth(
258 IDS_EXTENSION_WIPEOUT_BUBBLE_WIDTH_CHARS));
259 layout->AddView(extensions);
260 }
261
262 string16 action_button = delegate_->GetActionButtonLabel();
263
264 const int action_row_column_set_id = 3;
265 views::ColumnSet* bottom_columns =
266 layout->AddColumnSet(action_row_column_set_id);
267 bottom_columns->AddColumn(views::GridLayout::LEADING,
268 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
269 bottom_columns->AddPaddingColumn(1, 0);
270 bottom_columns->AddColumn(views::GridLayout::TRAILING,
271 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
272 if (!action_button.empty()) {
273 bottom_columns->AddColumn(views::GridLayout::TRAILING,
274 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
275 }
276 layout->StartRowWithPadding(0, action_row_column_set_id,
277 0, kMessageBubblePadding);
278
279 learn_more_ = new views::Link(delegate_->GetLearnMoreLabel());
280 learn_more_->set_listener(this);
281 layout->AddView(learn_more_);
282
283 if (!action_button.empty()) {
284 action_button_ = new views::LabelButton(this, action_button.c_str());
285 action_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
286 layout->AddView(action_button_);
287 }
288
289 dismiss_button_ = new views::LabelButton(this,
290 delegate_->GetDismissButtonLabel());
291 dismiss_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
292 layout->AddView(dismiss_button_);
293 }
294
295 void ExtensionMessageBubbleView::ButtonPressed(views::Button* sender,
296 const ui::Event& event) {
297 if (sender == action_button_) {
298 action_taken_ = true;
299 action_callback_.Run();
300 } else {
301 DCHECK_EQ(dismiss_button_, sender);
302 }
303 GetWidget()->Close();
304 }
305
306 void ExtensionMessageBubbleView::LinkClicked(views::Link* source,
307 int event_flags) {
308 DCHECK_EQ(learn_more_, source);
309 link_clicked_ = true;
310 link_callback_.Run();
311 GetWidget()->Close();
312 }
313
314 void ExtensionMessageBubbleView::GetAccessibleState(
315 ui::AccessibleViewState* state) {
316 state->role = ui::AccessibilityTypes::ROLE_ALERT;
317 }
318
319 void ExtensionMessageBubbleView::ViewHierarchyChanged(
320 const ViewHierarchyChangedDetails& details) {
321 if (details.is_add && details.child == this)
322 NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_ALERT, true);
323 }
324
325 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698