Add an extension bubble explaining which extensions are in dev mode.

chrome/browser/extensions/dev_mode_bubble_controller.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/dev_mode_bubble_controller.h"
+
+#include "base/bind.h"
+#include "base/metrics/histogram.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/extensions/extension_action_manager.h"
+#include "chrome/browser/extensions/extension_message_bubble.h"
+#include "chrome/browser/extensions/extension_prefs.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/common/url_constants.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
+#include "grit/chromium_strings.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace {
+
+static base::LazyInstance<extensions::ProfileKeyedAPIFactory<
+    extensions::DevModeBubbleController> >
+g_factory = LAZY_INSTANCE_INITIALIZER;
+
+}  // namespace
+
+namespace extensions {
+
+////////////////////////////////////////////////////////////////////////////////
+// DevModeBubbleController
+
+DevModeBubbleController::DevModeBubbleController(
+    Profile* profile)
+    : ExtensionMessageBubbleController(this, profile),
+      service_(extensions::ExtensionSystem::Get(profile)->extension_service()),
+      profile_(profile) {
+}
+
+DevModeBubbleController::~DevModeBubbleController() {
+}
+
+// static
+ProfileKeyedAPIFactory<DevModeBubbleController>*
+DevModeBubbleController::GetFactoryInstance() {
+  return &g_factory.Get();
+}
+
+// static
+DevModeBubbleController* DevModeBubbleController::Get(
+    Profile* profile) {
+  return ProfileKeyedAPIFactory<
+      DevModeBubbleController>::GetForProfile(profile);
+}
+
+bool DevModeBubbleController::IsDevModeExtension(
+    const Extension* extension) const {
+  return extension->location() == Manifest::UNPACKED ||
+         extension->location() == Manifest::COMMAND_LINE;
+}
+
+bool DevModeBubbleController::ShouldIncludeExtension(
+      const std::string& extension_id) {

[not at google - send to devlin, 2013/12/12 18:21:38]

I think generally methods should take Extensions not extension IDs since it
saves a lot of boilerplate in grabbing the ExtensionService, querying it for the
extension ID, then dealing with it not existing.

If this were passed an extension the the whole method would be just "return
IsDevModeExtension(extension)" (in fact that is probably what the funciton
should do anyway).

[Finnur, 2013/12/12 20:25:12]

Generally, yes. However, in this case, we want the implementors to decide for
themselves whether to include disabled extensions when they pull them from the
service. If the base class decides, it will have to pull disabled ones, because
the SuspiciousExtension bubble only cares about those. But the dev mode bubble
has no reason to highlight disabled extensions, so we'd have to replace the
boilerplate code for pulling the extension with boilerplate code to check if the
extension is disabled. In other words, I don't think we get much benefit.

However... more worryingly is that the next person who comes in and implements a
new bubble might not realize they are getting passed an extension* to a disabled
extension so I worry about bugs creeping in.

[not at google - send to devlin, 2013/12/12 21:17:19]

Ok that makes sense.

+  const Extension* extension = service_->GetExtensionById(extension_id, false);
+  if (!extension)
+    return false;
+  if (!IsDevModeExtension(extension))
+    return false;
+  return true;
+}
+
+void DevModeBubbleController::AcknowledgeExtension(
+    const std::string& extension_id,
+    ExtensionMessageBubbleController::BubbleAction user_action) {
+}
+
+void DevModeBubbleController::PerformAction(
+    const ExtensionIdList& list) {
+  for (size_t i = 0; i < list.size(); ++i)
+    service_->DisableExtension(list[i], Extension::DISABLE_USER_ACTION);

[not at google - send to devlin, 2013/12/12 18:21:38]

don't you want to disable the extensions on Chrome startup, not on bubble show?
The bubble show is purely informative?

[Finnur, 2013/12/12 20:25:12]

Not the DevMode bubble. It is meant to highlight dev mode extensions and ask the
user what to do with them. There's a disable button in that bubble, which
corresponds to this action.

+}
+
+string16 DevModeBubbleController::GetTitle() const {
+  return l10n_util::GetStringUTF16(IDS_EXTENSIONS_DISABLE_DEVELOPER_MODE_TITLE);
+}
+
+string16 DevModeBubbleController::GetMessageBody() const {
+  return l10n_util::GetStringUTF16(IDS_EXTENSIONS_DISABLE_DEVELOPER_MODE_BODY);
+}
+
+string16 DevModeBubbleController::GetOverflowText(
+    const string16& overflow_count) const {
+  return l10n_util::GetStringFUTF16(
+            IDS_EXTENSIONS_SUSPICIOUS_DISABLED_AND_N_MORE,
+            overflow_count);
+}
+
+string16 DevModeBubbleController::GetLearnMoreLabel() const {
+  return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
+}
+
+GURL DevModeBubbleController::GetLearnMoreUrl() const {
+  return GURL(chrome::kChromeUIExtensionsURL);
+}
+
+string16 DevModeBubbleController::GetActionButtonLabel() const {
+  return l10n_util::GetStringUTF16(IDS_DISABLE);
+}
+
+string16 DevModeBubbleController::GetDismissButtonLabel() const {
+  return l10n_util::GetStringUTF16(IDS_CANCEL);
+}
+
+bool DevModeBubbleController::ShouldShowExtensionList() const {
+  return false;
+}
+
+std::vector<string16> DevModeBubbleController::GetExtensions() {
+  return GetExtensionList();

[not at google - send to devlin, 2013/12/12 18:21:38]

calling from the Delegate back into the Controller is an inversion of what a
Delegate is supposed to be; I guess that's another reason not to make this class
extend Controller. See comment in the view.

+}
+
+void DevModeBubbleController::LogExtensionCount(size_t count) {
+  UMA_HISTOGRAM_COUNTS_100(
+      "DevModeExtensionBubble.ExtensionsInDevModeCount", count);
+}
+
+void DevModeBubbleController::LogAction(
+    ExtensionMessageBubbleController::BubbleAction action) {
+  UMA_HISTOGRAM_ENUMERATION(
+      "DevModeExtensionBubble.UserSelection",
+      action, ExtensionMessageBubbleController::ACTION_BOUNDARY);
+}
+
+template <>
+void ProfileKeyedAPIFactory<
+    DevModeBubbleController>::DeclareFactoryDependencies() {
+  DependsOn(extensions::ExtensionSystemFactory::GetInstance());
+}
+
+}  // namespace extensions