Add an extension bubble explaining which extensions are in dev mode.

chrome/browser/extensions/extension_message_bubble_controller.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
+
+#include <string>
+#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
+#include "chrome/browser/extensions/extension_message_bubble.h"
+#include "extensions/common/extension.h"
+
+class Browser;
+class ExtensionService;
+
+namespace extensions {
+
+class ExtensionPrefs;
+class SuspiciousExtensionBubble;
+
+class ExtensionMessageBubbleController {
+ public:
+  // UMA histogram constants.
+  enum BubbleAction {
+    ACTION_LEARN_MORE = 0,
+    ACTION_EXECUTE,
+    ACTION_DISMISS,
+    ACTION_BOUNDARY, // Must be the last value.
+  };
+
+  class Delegate {
+   public:
+    virtual void Show(ExtensionMessageBubble* bubble) = 0;
+    virtual bool ShowingBubble() const = 0;
+    virtual bool HasExtensionList() const = 0;
+    virtual std::vector<string16> GetExtensionList() const = 0;
+    virtual const ExtensionIdList& GetExtensionIdList() const = 0;

[not at google - send to devlin, 2013/12/10 01:21:39]

is this used?

[Finnur, 2013/12/11 23:12:18]

It was used in the last CL but no longer. Removed.

+    virtual bool ShouldIncludeExtension(const std::string& extension_id) = 0;
+    virtual void AcknowledgeExtension(
+        const std::string& extension_id,
+        BubbleAction action) = 0;
+    virtual void PerformAction(const ExtensionIdList& list) = 0;
+
+    // Text for various UI labels shown in the bubble.
+    virtual string16 GetTitle() const = 0;
+    virtual string16 GetMessageBody() const = 0;
+    virtual string16 GetOverflowText(const string16& overflow_count) const = 0;
+    virtual string16 GetLearnMoreLabel() const = 0;
+    virtual GURL GetLearnMoreUrl() const = 0;
+    virtual string16 GetActionButtonLabel() const = 0;
+    virtual string16 GetDismissButtonLabel() const = 0;
+
+    // Whether to show a list of extensions in the bubble.
+    virtual bool ShouldShowExtensionList() const = 0;

[not at google - send to devlin, 2013/12/10 01:21:39]

this seems to always return true, also, it doesn't seem so necessary given
HasExtensionList, also it doesn't appear to be used.

[Finnur, 2013/12/11 23:12:18]

It is used in the view.

The decision has been going back and forth on whether we want to show the full
extension list in the dev mode bubble. Now the word on the street is that we do
not want that, so this is now not always returning false.

+
+    // Record, through UMA, how many extensions were found.
+    virtual void LogExtensionCount(size_t count) = 0;
+    virtual void LogAction(BubbleAction action) = 0;
+  };
+
+  ExtensionMessageBubbleController(Delegate* delegate, Profile* profile);
+  virtual ~ExtensionMessageBubbleController();
+
+  // Whether the controller knows of extensions to list in the bubble. Returns
+  // true if so.
+  bool HasExtensionList();
+
+  // Obtains a list of all extensions (by name) the controller knows about.
+  std::vector<string16> GetExtensionList() const;
+
+  // Obtains a list of all extensions (by id) the controller knows about.
+  const ExtensionIdList& extension_id_list() const {
+    return extension_list_;
+  }
+
+  // Sets up the callbacks and shows the bubble.
+  void Show(ExtensionMessageBubble* bubble);
+
+  // Whether the bubble is currently showing.
+  bool showing_bubble() { return showing_bubble_; }
+
+  // Callbacks from bubble. Declared virtual for testing purposes.
+  virtual void OnBubbleAction();
+  virtual void OnBubbleDismiss();
+  virtual void OnLinkClicked();
+
+  // Iterate over the known extensions and acknowledge each one.
+  void AcknowledgeExtensions();
+
+  // Our extension service. Weak, not owned by us.
+  ExtensionService* service_;
+
+  // A weak pointer to the profile we are associated with. Not owned by us.
+  Profile* profile_;
+
+  // The list of extensions found.
+  ExtensionIdList extension_list_;
+
+  // The action the user took in the bubble.
+  BubbleAction user_action_;
+
+  Delegate* delegate_;
+
+  // This object only checks once for suspicious extensions because the dataset
+  // doesn't change after startup.
+  bool has_notified_;
+
+  // Whether the bubble is currently showing.
+  bool showing_bubble_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_