Issue 95123003: Fix bug in inlining Function.apply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 95123003: Fix bug in inlining Function.apply. (Closed)

Created:
7 years ago by Yang

Modified:
7 years ago

Reviewers:
Michael Starzinger, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug in inlining Function.apply. R=jkummerow@chromium.org BUG=323942 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=18135

Patch Set 3 : #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -21 lines)			Patch
	M	src/hydrogen.cc	View	1 2	1 chunk	+7 lines, -0 lines	2 comments	Download
	A +	test/mjsunit/regress/regress-crbug-323942.js	View	1 2	1 chunk	+22 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a comment. https://codereview.chromium.org/95123003/diff/10001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/95123003/diff/10001/src/hydrogen.cc#newcode7566 src/hydrogen.cc:7566: return false; I think we ...

7 years ago (2013-11-28 15:17:30 UTC) #2

Michael Starzinger

7 years ago (2013-11-28 16:01:25 UTC) #4

Message was sent while issue was closed.

Unfortunately not LGTM.

https://codereview.chromium.org/95123003/diff/30001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/95123003/diff/30001/src/hydrogen.cc#newcode7567
src/hydrogen.cc:7567: return false;
I don't think it is safe to bail out at this point, this will cause prop->obj()
to be visited twice. That might be an arbitrary complex expression (maybe with
side-effects). IMHO, the correct fix is further down ...

https://codereview.chromium.org/95123003/diff/30001/src/hydrogen.cc#newcode7600
src/hydrogen.cc:7600: if (function->IsConstant()) {
... here, because that is the only place where the constant function is actually
inspected unsafely.

Expand Messages | Collapse Messages

Issue 95123003: Fix bug in inlining Function.apply. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages