Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 951223002: Enable ServiceWorkerMicroBenchmarkPerfTest (service_worker.service_worker_micro_benchmark) (Closed)

Created:
5 years, 10 months ago by horo
Modified:
5 years, 10 months ago
Reviewers:
falken, nednguyen, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ServiceWorkerMicroBenchmarkPerfTest (service_worker.service_worker_micro_benchmark) I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness. BUG=442752 TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker_micro_benchmark Committed: https://crrev.com/79b35fe9bc28e4e1a2a10ce26edc5d8b46fb362f Cr-Commit-Position: refs/heads/master@{#317805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
horo
falken@ Could you please review?
5 years, 10 months ago (2015-02-24 05:50:06 UTC) #2
falken
On 2015/02/24 05:50:06, horo wrote: > falken@ > Could you please review? nice lgtm
5 years, 10 months ago (2015-02-24 05:55:50 UTC) #3
horo
nednguyen@ Could you please review this? Thank you.
5 years, 10 months ago (2015-02-24 06:02:22 UTC) #5
sullivan
lgtm I'm going to lgtm+cq this so there is a bit more time for it ...
5 years, 10 months ago (2015-02-24 14:08:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951223002/1
5 years, 10 months ago (2015-02-24 14:09:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 17:05:25 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/79b35fe9bc28e4e1a2a10ce26edc5d8b46fb362f Cr-Commit-Position: refs/heads/master@{#317805}
5 years, 10 months ago (2015-02-24 17:06:13 UTC) #11
Ilya Sherman
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/943043004/ by isherman@chromium.org. ...
5 years, 10 months ago (2015-02-24 21:56:32 UTC) #12
sullivan
On 2015/02/24 21:56:32, Ilya Sherman wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 10 months ago (2015-02-24 21:59:30 UTC) #13
horo
5 years, 10 months ago (2015-02-25 00:01:53 UTC) #14
Message was sent while issue was closed.
On 2015/02/24 21:59:30, sullivan wrote:
> On 2015/02/24 21:56:32, Ilya Sherman wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/943043004/ by mailto:isherman@chromium.org.
> > 
> > The reason for reverting is: This immediately re-introduced redness on the
> tree:
> > 
> > http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20(2)
> >
>
http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%282%29/b....
> 
> Note: this only broke on reference builds, which are currently M37. Does this
> test depend on functionality which is only available in later builds? If so,
can
> @Disable("reference"), with a comment about which version the reference build
> needs to be rolled past to enable. We're currently working on making the
> reference build be stable release.

Ah, yes. I forgot about it.
I created a CL "Reenable all except for ref and XP build of
service_worker_micro_benchmark"
https://codereview.chromium.org/951883006/

Powered by Google App Engine
This is Rietveld 408576698