Make CSSRuleSourceData use the CSSRule Type enum

Make CSSRuleSourceData use the CSSRule Type enum

Since CSSRule::Type encompasses CSSRuleSourceData::Type, use
the former everywhere and remove the latter, to avoid any
confusion between the two roughly equivalent enums.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190972

[rwlbuis, 2015-02-26 22:34:28]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-02-26 22:34:29]

PTAL

[Timothy Loh, 2015-02-26 22:51:53]

On 2015/02/26 22:34:29, rwlbuis wrote:
> PTAL

lgtm if you make it use StyleRule::Type instead (CSSRule is for CSSOM objects,
so normally we have lots of StyleRules and no CSSRules), sorry about the
slightly-wrong fixme.

[rwlbuis, 2015-02-26 23:46:30]

On 2015/02/26 22:51:53, Timothy Loh wrote:
> On 2015/02/26 22:34:29, rwlbuis wrote:
> > PTAL
> 
> lgtm if you make it use StyleRule::Type instead (CSSRule is for CSSOM objects,
> so normally we have lots of StyleRules and no CSSRules), sorry about the
> slightly-wrong fixme.

Got it. Patch set 3 has that change (I'd still need to update the description
log).
Note some changes:

- I had to add Unknown to StyleRule::Type and add it to switches.
- CHARSET_RULE is removed from InspectorStyleSheet.cpp, but I think we
are not constructing them anyway.
- CSSRuleSourceData::createUnknown was unused, removed :)

[Timothy Loh, 2015-02-26 23:56:00]

On 2015/02/26 23:46:30, rwlbuis wrote:
> On 2015/02/26 22:51:53, Timothy Loh wrote:
> > On 2015/02/26 22:34:29, rwlbuis wrote:
> > > PTAL
> > 
> > lgtm if you make it use StyleRule::Type instead (CSSRule is for CSSOM
objects,
> > so normally we have lots of StyleRules and no CSSRules), sorry about the
> > slightly-wrong fixme.
> 
> Got it. Patch set 3 has that change (I'd still need to update the description
> log).
> Note some changes:
> 
> - I had to add Unknown to StyleRule::Type and add it to switches.
> - CHARSET_RULE is removed from InspectorStyleSheet.cpp, but I think we
> are not constructing them anyway.
> - CSSRuleSourceData::createUnknown was unused, removed :)

Still lgtm. I guess we'll delete StyleRule::Unknown once the Bison parser is
gone.

[rwlbuis, 2015-02-27 00:03:58]

On 2015/02/26 23:56:00, Timothy Loh wrote:
> On 2015/02/26 23:46:30, rwlbuis wrote:
> > On 2015/02/26 22:51:53, Timothy Loh wrote:
> > > On 2015/02/26 22:34:29, rwlbuis wrote:
> > > > PTAL
> > > 
> > > lgtm if you make it use StyleRule::Type instead (CSSRule is for CSSOM
> objects,
> > > so normally we have lots of StyleRules and no CSSRules), sorry about the
> > > slightly-wrong fixme.
> > 
> > Got it. Patch set 3 has that change (I'd still need to update the
description
> > log).
> > Note some changes:
> > 
> > - I had to add Unknown to StyleRule::Type and add it to switches.
> > - CHARSET_RULE is removed from InspectorStyleSheet.cpp, but I think we
> > are not constructing them anyway.
> > - CSSRuleSourceData::createUnknown was unused, removed :)
> 
> Still lgtm. I guess we'll delete StyleRule::Unknown once the Bison parser is
> gone.

Yes lots of cleanup left once Bison parser is gone I suppose.
Thanks, I'll commit it then.

[rwlbuis, 2015-02-27 00:04:06]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-02-27 00:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951213004/40001

[commit-bot: I haz the power, 2015-02-27 03:33:33]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190972