Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 95113005: [SyncFS] Add bulk update method to MetadataDatabase (Closed)

Created:
7 years ago by tzik
Modified:
7 years ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki
Visibility:
Public.

Description

[SyncFS] Add bulk update method to MetadataDatabase Adding a helper for folder create-create conflict handling. BUG=240165 R=kinuko@chromium.org, nhiroki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238894

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tzik
PTL
7 years ago (2013-12-04 10:59:04 UTC) #1
nhiroki
lgtm
7 years ago (2013-12-04 11:02:43 UTC) #2
kinuko
lgtm https://codereview.chromium.org/95113005/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.h File chrome/browser/sync_file_system/drive_backend/metadata_database.h (right): https://codereview.chromium.org/95113005/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.h#newcode254 chrome/browser/sync_file_system/drive_backend/metadata_database.h:254: void UpdateByDeletedRemoteFile(const std::string& file_id, While you're here could ...
7 years ago (2013-12-04 12:45:06 UTC) #3
tzik
https://codereview.chromium.org/95113005/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.h File chrome/browser/sync_file_system/drive_backend/metadata_database.h (right): https://codereview.chromium.org/95113005/diff/1/chrome/browser/sync_file_system/drive_backend/metadata_database.h#newcode254 chrome/browser/sync_file_system/drive_backend/metadata_database.h:254: void UpdateByDeletedRemoteFile(const std::string& file_id, On 2013/12/04 12:45:06, kinuko wrote: ...
7 years ago (2013-12-05 04:00:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/95113005/1
7 years ago (2013-12-05 04:01:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=39582
7 years ago (2013-12-05 04:14:40 UTC) #6
tzik
7 years ago (2013-12-05 04:34:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r238894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698