Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 951083002: Disable container overflow check on Linux and Mac. (Closed)

Created:
5 years, 10 months ago by inferno
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable container overflow check on Linux and Mac. BUG=459632 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/6c3ce96dedaf8f23fce9cbd9c5279fe20c531ac6 Cr-Commit-Position: refs/heads/master@{#317681}

Patch Set 1 #

Patch Set 2 : space nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/sanitizers/sanitizer_options.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
marcheu
Thanks for fixing this! LGTM
5 years, 10 months ago (2015-02-23 23:36:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951083002/20001
5 years, 10 months ago (2015-02-23 23:52:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 23:54:24 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6c3ce96dedaf8f23fce9cbd9c5279fe20c531ac6 Cr-Commit-Position: refs/heads/master@{#317681}
5 years, 10 months ago (2015-02-23 23:55:54 UTC) #7
inferno
5 years, 8 months ago (2015-04-08 16:55:43 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1069793002/ by inferno@chromium.org.

The reason for reverting is: Container overflow is stable on linux, we can
safely revert it..

Powered by Google App Engine
This is Rietveld 408576698