Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 951063006: Add a script to download material design assets from gs (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
jamesr, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a script to download material design assets from gs We're going to use these assets to make pretty demos of Sky but not every developer needs them in their working copy. R=eseidel@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3b9942dd17bbb90d14f0cf2258dca0e07661ab7d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A sky/assets/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A sky/assets/material-design-icons.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A sky/tools/download_material_design_icons View 1 chunk +35 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-24 00:18:12 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-24 01:25:21 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 3b9942dd17bbb90d14f0cf2258dca0e07661ab7d (presubmit successful).
5 years, 10 months ago (2015-02-24 01:25:47 UTC) #4
jamesr
5 years, 10 months ago (2015-02-24 22:09:49 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/951063006/diff/1/sky/tools/download_material_...
File sky/tools/download_material_design_icons (right):

https://codereview.chromium.org/951063006/diff/1/sky/tools/download_material_...
sky/tools/download_material_design_icons:10: from webkitpy.common.webkit_finder
import WebKitFinder
lol

Powered by Google App Engine
This is Rietveld 408576698