Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 951063004: ozone: evdev: Keep track of settings & apply to new devices (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Keep track of settings & apply to new devices This closes two large holes in the settings code: (1) Any changes made before the input device thread starts are lost. (2) Settings are not internally applied to new devices on hotplug. In theory these problems should not have mattered because there is a DeviceChangeHandler class to watch for new devices & reapply settings whenever a new device appears. However, in practice that class is not actually instantiated. We've had several reports of settings not being properly applied. To fix (1) build up desired settings state on the UI thread in InputControllerEvdev, and push it to InputDeviceFactoryEvdev once the thread starts. To fix (2) keep the desired settings state on InputDeviceFactoryEvdev, and reapply settings on hotplug. BUG=451743 TEST=Turned on australian scrolling & ran "sudo restart udev" on link_freon. Verified scrolling is still australian. Committed: https://crrev.com/8ec6aaa574230d326a602f1cd719cfff227e4279 Cr-Commit-Position: refs/heads/master@{#317851}

Patch Set 1 #

Patch Set 2 : fix tap dragging #

Patch Set 3 : s/class/struct/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -99 lines) Patch
M ui/events/ozone/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.h View 3 chunks +16 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.cc View 1 6 chunks +35 lines, -16 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 4 chunks +8 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 3 chunks +32 lines, -29 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev_proxy.h View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev_proxy.cc View 1 chunk +4 lines, -39 lines 0 comments Download
A ui/events/ozone/evdev/input_device_settings_evdev.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/input_device_settings_evdev.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
spang
5 years, 10 months ago (2015-02-23 23:23:10 UTC) #2
alexst (slow to review)
lgtm
5 years, 10 months ago (2015-02-23 23:41:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951063004/40001
5 years, 10 months ago (2015-02-24 19:05:40 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-24 19:25:13 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 19:25:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ec6aaa574230d326a602f1cd719cfff227e4279
Cr-Commit-Position: refs/heads/master@{#317851}

Powered by Google App Engine
This is Rietveld 408576698