DescriptionMac: Fix bookmark button drawing regression
When the bookmark bar is hidden, BookmarkBarToolbarView's height
is set to 0.
Before https://crrev.com/924143002/, when BookmarkButton calls its
drawRect through cr_drawUsingAncestor, it was filling its bounds,
effectively drawing nothing.
After the change, it was filling |dirtyRect|, so it was drawing the SHOW
state even though its bounds has 0 height.
The whole thing is fragile and can probably be done better, but we should
not ask the ancestor to draw outside its bounds anyway, thus this fix.
BUG=459992
Committed: https://crrev.com/489df883d4431e11e72d5007eda8f8de7f129f46
Cr-Commit-Position: refs/heads/master@{#317693}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|