Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 951063002: Mac: Fix bookmark button drawing regression (Closed)

Created:
5 years, 10 months ago by Andre
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tracking
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix bookmark button drawing regression When the bookmark bar is hidden, BookmarkBarToolbarView's height is set to 0. Before https://crrev.com/924143002/, when BookmarkButton calls its drawRect through cr_drawUsingAncestor, it was filling its bounds, effectively drawing nothing. After the change, it was filling |dirtyRect|, so it was drawing the SHOW state even though its bounds has 0 height. The whole thing is fragile and can probably be done better, but we should not ask the ancestor to draw outside its bounds anyway, thus this fix. BUG=459992 Committed: https://crrev.com/489df883d4431e11e72d5007eda8f8de7f129f46 Cr-Commit-Position: refs/heads/master@{#317693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/base/cocoa/nsview_additions.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
Robert, please review.
5 years, 10 months ago (2015-02-23 22:53:15 UTC) #2
Robert Sesek
lgtm
5 years, 10 months ago (2015-02-24 00:06:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951063002/1
5 years, 10 months ago (2015-02-24 00:24:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 00:41:29 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:42:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489df883d4431e11e72d5007eda8f8de7f129f46
Cr-Commit-Position: refs/heads/master@{#317693}

Powered by Google App Engine
This is Rietveld 408576698