Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 951003002: Use highp for distance field texture coord varyings. (Closed)

Created:
5 years, 10 months ago by jvanverth1
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use highp for distance field texture coord varyings. Because the glyph texture atlas is 1024x2048, on certain platforms using mediump UVs is not enough resolution for doing texture lookups and getting good results for distance fields. Bumping these to highp solves this problem. BUG=skia:3445 Committed: https://skia.googlesource.com/skia/+/9671ecd44e48e8bbe1361830717b79c9c4dc9d17

Patch Set 1 #

Patch Set 2 : Add highp to other DF shaders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jvanverth1
5 years, 10 months ago (2015-02-23 20:33:49 UTC) #2
jvanverth1
Forgot to update this for the other distance field shaders -- can hold off on ...
5 years, 10 months ago (2015-02-23 20:39:36 UTC) #3
jvanverth1
On 2015/02/23 20:39:36, jvanverth1 wrote: > Forgot to update this for the other distance field ...
5 years, 10 months ago (2015-02-23 20:53:37 UTC) #4
bsalomon
lgtm
5 years, 10 months ago (2015-02-23 20:55:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951003002/20001
5 years, 10 months ago (2015-02-23 21:01:29 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 21:08:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9671ecd44e48e8bbe1361830717b79c9c4dc9d17

Powered by Google App Engine
This is Rietveld 408576698