Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 950993003: On Windows, if intention for shared memory name is empty then we pass NULL. (Closed)

Created:
5 years, 10 months ago by Shrikant Kelkar
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On Windows, if intention for shared memory name is empty then we pass NULL. With new appcontainer token in picture, it fails to create shared memory with empty name like "", it explicity seem to need NULL for anonymous. BUG=455496 R=cpu Committed: https://crrev.com/9426fb80a0cc758ed9686c48bb7642d23c229cfa Cr-Commit-Position: refs/heads/master@{#317689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/memory/shared_memory_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Shrikant Kelkar
5 years, 10 months ago (2015-02-23 21:29:20 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-23 23:16:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950993003/1
5 years, 10 months ago (2015-02-23 23:17:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 00:27:48 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:29:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9426fb80a0cc758ed9686c48bb7642d23c229cfa
Cr-Commit-Position: refs/heads/master@{#317689}

Powered by Google App Engine
This is Rietveld 408576698