Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 950973002: Temporarily make find_xcode.py prefix match on the tryserver (Closed)

Created:
5 years, 10 months ago by smut
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Temporarily make find_xcode.py prefix match on the tryserver The bots (incorrectly) have a mix of Xcode 5.1 and 5.1.1 installed. This is causing failures. So for the time being, I'm converting the script to accept 5.1.1 when 5.1 is expected. BUG=461005 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M scripts/slave/ios/find_xcode.py View 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
smut
5 years, 10 months ago (2015-02-23 19:18:03 UTC) #2
smut
On 2015/02/23 19:18:03, smut wrote: Ignore try job results, can't apply this patch because this ...
5 years, 10 months ago (2015-02-23 19:20:17 UTC) #3
stuartmorgan
LGTM to stop the bleeding. Long-term though, do we really want strict enforcement rather than ...
5 years, 10 months ago (2015-02-23 19:23:27 UTC) #4
Sergey Berezin
LGTM as well. Thanks!
5 years, 10 months ago (2015-02-23 19:24:15 UTC) #6
smut
On 2015/02/23 19:23:27, stuartmorgan wrote: > LGTM to stop the bleeding. > > Long-term though, ...
5 years, 10 months ago (2015-02-23 19:27:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950973002/1
5 years, 10 months ago (2015-02-23 19:27:53 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:30:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294176

Powered by Google App Engine
This is Rietveld 408576698