Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 950963003: Never layer-ize RenderInlines. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Never layer-ize RenderInlines. This removes support for opacity, filters and clip-path on RenderInlines. If you want inline content that uses these properties you need to use an inline-block. We may want to add back support for opacity or filters on inlines eventually, but we'd implement it differently and right now they're getting in the way. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/952eb114ab0d01683e5bc41dd566a37e4a8f3978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/engine/core/rendering/RenderInline.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-23 23:46:51 UTC) #2
ojan
5 years, 10 months ago (2015-02-24 00:40:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
952eb114ab0d01683e5bc41dd566a37e4a8f3978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698