Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 950963002: Decouple WebViewImpl from WebView attributes (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decouple WebViewImpl from WebView attributes Ideally web_view.js show know as little as possible about the internals of WebView attributes and vice versa. This will allow WebView attributes to eventually become GuestView attributes that can be shared with other GuestViewContainer types. This CL takes us in that direction by plumbing attach/detach into attributes which can then decide how to respond to those events. BUG=none TBR=lazyboy@chromium.org Committed: https://crrev.com/b2ff547e446523ba3b253a6fd9f1b3920f1f9632 Cr-Commit-Position: refs/heads/master@{#317744}

Patch Set 1 #

Patch Set 2 : Fixed broken test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M extensions/renderer/resources/guest_view/web_view.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_attributes.js View 1 7 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Fady Samuel
5 years, 10 months ago (2015-02-23 19:14:24 UTC) #2
paulmeyer
LGTM! Nice style fixes too!
5 years, 10 months ago (2015-02-23 19:26:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950963002/1
5 years, 10 months ago (2015-02-23 19:40:59 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-23 19:41:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950963002/1
5 years, 10 months ago (2015-02-23 19:43:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/28314)
5 years, 10 months ago (2015-02-23 23:48:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950963002/20001
5 years, 10 months ago (2015-02-24 01:25:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 02:22:31 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 02:25:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2ff547e446523ba3b253a6fd9f1b3920f1f9632
Cr-Commit-Position: refs/heads/master@{#317744}

Powered by Google App Engine
This is Rietveld 408576698