Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 950923002: Convert CC HUD from GDI bitmap to SkSurface (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@revert-win32k-font
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
scottmg
5 years, 10 months ago (2015-02-23 20:36:08 UTC) #2
danakj
LGTM
5 years, 10 months ago (2015-02-23 20:45:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950923002/40001
5 years, 10 months ago (2015-02-23 21:25:54 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-23 23:07:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950923002/40001
5 years, 10 months ago (2015-02-23 23:09:40 UTC) #11
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-23 23:11:01 UTC) #13
scottmg
What a helpful message.
5 years, 10 months ago (2015-02-23 23:15:17 UTC) #15
danakj
On 2015/02/23 23:15:17, scottmg wrote: > What a helpful message. lol :(
5 years, 10 months ago (2015-02-23 23:17:36 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/536a54016bef88b8efb26fc59e29bfc8dcc36d94 Cr-Commit-Position: refs/heads/master@{#317675}
5 years, 10 months ago (2015-02-23 23:24:14 UTC) #17
scottmg
5 years, 10 months ago (2015-02-23 23:24:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
536a54016bef88b8efb26fc59e29bfc8dcc36d94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698