Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 950903003: add tools/dm_flags.py (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : missed a word #

Patch Set 3 : chmod +x #

Patch Set 4 : sort imports #

Patch Set 5 : delay coverage import #

Total comments: 4

Patch Set 6 : borenet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -0 lines) Patch
A tools/dm_flags.json View 1 chunk +137 lines, -0 lines 0 comments Download
A tools/dm_flags.py View 1 2 3 4 5 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
5 years, 10 months ago (2015-02-23 21:46:11 UTC) #2
borenet
LGTM https://codereview.chromium.org/950903003/diff/80001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/950903003/diff/80001/tools/dm_flags.py#newcode9 tools/dm_flags.py:9: Nit: 2 lines between top-level defs https://codereview.chromium.org/950903003/diff/80001/tools/dm_flags.py#newcode113 tools/dm_flags.py:113: ...
5 years, 10 months ago (2015-02-24 14:39:45 UTC) #3
mtklein
https://codereview.chromium.org/950903003/diff/80001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/950903003/diff/80001/tools/dm_flags.py#newcode9 tools/dm_flags.py:9: On 2015/02/24 14:39:45, borenet wrote: > Nit: 2 lines ...
5 years, 10 months ago (2015-02-24 15:02:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950903003/100001
5 years, 10 months ago (2015-02-24 15:03:00 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 17:25:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/11a2c503bd773572352a39fa4aef5d506ecfefbb

Powered by Google App Engine
This is Rietveld 408576698