Add exit code for infra failures to testrunner script.

build/android/test_runner.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs all types of tests from one unified interface."""
 
 import argparse
 import collections
 import logging
 import os
 import shutil
 import signal
 import sys
 import threading
 import unittest
 
 from pylib import android_commands
 from pylib import constants
 from pylib import forwarder
 from pylib import ports
+from pylib.base import base_error
 from pylib.base import base_test_result
 from pylib.base import environment_factory
 from pylib.base import test_dispatcher
 from pylib.base import test_instance_factory
 from pylib.base import test_run_factory
 from pylib.gtest import gtest_config
 from pylib.gtest import setup as gtest_setup
 from pylib.gtest import test_options as gtest_test_options
 from pylib.linker import setup as linker_setup
 from pylib.host_driven import setup as host_driven_setup
@@ skipping 917 matching lines @@
             results=results,
             test_type=test.TestType(),
             test_package=test_run.TestPackage(),
             annotation=getattr(args, 'annotations', None),
             flakiness_server=getattr(args, 'flakiness_dashboard_server', None))
 
         if args.json_results_file:
           json_results.GenerateJsonResultsFile(
               results, args.json_results_file)
 
-  return 0 if results.DidRunPass() else 1
+  return 0 if results.DidRunPass() else constants.ERROR_EXIT_CODE
 
 
 CommandConfigTuple = collections.namedtuple(
     'CommandConfigTuple',
     ['add_options_func', 'help_txt'])
 VALID_COMMANDS = {
     'gtest': CommandConfigTuple(
         AddGTestOptions,
         'googletest-based C++ tests'),
     'instrumentation': CommandConfigTuple(
@@ skipping 35 matching lines @@
   command_parsers = parser.add_subparsers(title='test types',
                                           dest='command')
 
   for test_type, config in sorted(VALID_COMMANDS.iteritems(),
                                   key=lambda x: x[0]):
     subparser = command_parsers.add_parser(
         test_type, usage='%(prog)s [options]', help=config.help_txt)
     config.add_options_func(subparser)
 
   args = parser.parse_args()
-  return RunTestsCommand(args, parser)
+
+  try:
+    return RunTestsCommand(args, parser)
+  except base_error.BaseError as e:
+    logging.exception('An error occured.')

[mikecase (-- gone --), 2015/02/23 22:29:27]

Just fyi.

logging.exception WILL print the error message of the exception, but it also
requires you pass it a message... so I just had to give it something super
generic  :/

[jbudorick, 2015/02/23 22:31:29]

We could split by infra / non-infra?

What does this wind up looking like?

[mikecase (-- gone --), 2015/02/23 22:48:22]

Wrote a quick example. Output of logging.exception looks something like this....

ERROR:root:"Logging.exception message."
Traceback (most recent call last):
  File "test.py", line 23, in <module>
    level1()
  File "test.py", line 13, in level1
    level2()
  File "test.py", line 16, in level2
    level3()
  File "test.py", line 19, in level3
    raise CustomException('"Custom exception message."')
CustomException: "Custom exception message."

Looks like it will print all the information we would need. We could even change
it to logging.exception(''), but that could be confusing to read.

+    if e.is_infra_error:
+      return constants.INFRA_EXIT_CODE
+    else:
+      return constants.ERROR_EXIT_CODE
 
 
 if __name__ == '__main__':
   sys.exit(main())