Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 950873003: Revert "The expected key is a valid identifier, which is already free of \\, <0x20, "." (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "The expected key is a valid identifier, which is already free of \\, <0x20, "." The optimization is invalid as indicated by the test. BUG= TBR=yangguo@chromium.org Committed: https://crrev.com/460187b56390cd423f68558cafd9924e7b71d4fa Cr-Commit-Position: refs/heads/master@{#26799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/json-parser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/mjsunit/json2.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950873003/1
5 years, 10 months ago (2015-02-23 17:16:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 17:57:10 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/460187b56390cd423f68558cafd9924e7b71d4fa Cr-Commit-Position: refs/heads/master@{#26799}
5 years, 10 months ago (2015-02-23 17:57:29 UTC) #5
Yang
5 years, 10 months ago (2015-02-24 07:29:18 UTC) #6
Message was sent while issue was closed.
On 2015/02/23 17:57:29, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/460187b56390cd423f68558cafd9924e7b71d4fa
> Cr-Commit-Position: refs/heads/master@{#26799}

lgtm.

Powered by Google App Engine
This is Rietveld 408576698