Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 950863002: Allow specification of the version file for download_shell_binary to use. (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow specification of the version file for download_shell_binary to use. download_shell_binary.py assumes the presence of a //mojo/public/VERSION file that contains the SHA1 corresponding to the shell version to fetch. However, this file is not present in the Mojo repo, and hence not present in the SDK mirror. This CL allows the client of download_shell_binary.py to specify the path to the version file to allow maintaining the version file outside of the SDK itself when using the mirror. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6a6cc936c631fedd2c23022e49d6ed1969e6965a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M mojo/public/tools/download_shell_binary.py View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
blundell
Hi James, I realized that the approach of obtaining the shell version to fetch from ...
5 years, 10 months ago (2015-02-23 15:51:22 UTC) #2
jamesr
lgtm
5 years, 10 months ago (2015-02-23 19:09:53 UTC) #3
blundell
5 years, 10 months ago (2015-02-24 09:10:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a6cc936c631fedd2c23022e49d6ed1969e6965a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698