Change initDataType and sessionType to be enums

Change initDataType and sessionType to be enums

BUG=418239
TEST=EME tests still pass

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190890

[jrummell, 2015-02-25 00:22:29]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2015-02-25 00:22:30]

PTAL. Doesn't include changes to struct WebMediaKeySystemConfiguration, since
that will be more complicated.

[sandersd (OOO until July 31), 2015-02-25 00:35:54]

lgtm

https://codereview.chromium.org/950813005/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/950813005/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:468: scriptState,
DOMException::create(NotSupportedError, "The initialization data type '" +
initDataTypeString + "' is not a registered Initialization Data Type."));
I don't think that 'registered' has meaning to developers; just saying 'is not
supported' may be more clear.

https://codereview.chromium.org/950813005/diff/1/public/platform/WebEncrypted...
File public/platform/WebEncryptedMediaTypes.h (right):

https://codereview.chromium.org/950813005/diff/1/public/platform/WebEncrypted...
public/platform/WebEncryptedMediaTypes.h:13: Cenc,
Are these capitalizations standard for WebKit?

[jrummell, 2015-02-25 20:52:42]

jrummell@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[jrummell, 2015-02-25 20:52:42]

Updated.
+dcheng@ for OWNERS review of public/platform
+haraken@ for OWNERS review of source/platform and source/web

https://codereview.chromium.org/950813005/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/950813005/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:468: scriptState,
DOMException::create(NotSupportedError, "The initialization data type '" +
initDataTypeString + "' is not a registered Initialization Data Type."));
On 2015/02/25 00:35:54, sandersd wrote:
> I don't think that 'registered' has meaning to developers; just saying 'is not
> supported' may be more clear.

Done.

https://codereview.chromium.org/950813005/diff/1/public/platform/WebEncrypted...
File public/platform/WebEncryptedMediaTypes.h (right):

https://codereview.chromium.org/950813005/diff/1/public/platform/WebEncrypted...
public/platform/WebEncryptedMediaTypes.h:13: Cenc,
On 2015/02/25 00:35:54, sandersd wrote:
> Are these capitalizations standard for WebKit?

Appear to be. In the past we used names like
WebContentDecryptionModuleExceptionNotSupportedError, but with enum class it
needs to be qualified, so having
WebEncryptedMediaInitDataType::WebEncryptedMediaInitDataTypeCenc seemed
redundant.

Existing example:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[dcheng, 2015-02-25 20:55:11]

rs lgtm

[ddorwin, 2015-02-25 21:00:05]

I just skimmed it. LG overall.

https://codereview.chromium.org/950813005/diff/20001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/950813005/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:58: // The list of possible
values for |initDataType|.
To avoid the temptation to use these, I wonder if it makes sense to define all
these strings within the conversion functions only.

https://codereview.chromium.org/950813005/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:59: const char kCenc[] =
"cenc";
These are defined in two places. Is there a common file we can use?

[haraken, 2015-02-25 21:08:42]

platform/ and web/ LGTM.

[jrummell, 2015-02-25 21:35:15]

Updated to remove constant strings.

https://codereview.chromium.org/950813005/diff/20001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/950813005/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:58: // The list of possible
values for |initDataType|.
On 2015/02/25 21:00:04, ddorwin wrote:
> To avoid the temptation to use these, I wonder if it makes sense to define all
> these strings within the conversion functions only.

Done.

https://codereview.chromium.org/950813005/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:59: const char kCenc[] =
"cenc";
On 2015/02/25 21:00:05, ddorwin wrote:
> These are defined in two places. Is there a common file we can use?

Not really. Will consider a utils file in a future CL.

[ddorwin, 2015-02-25 21:38:51]

LG

https://codereview.chromium.org/950813005/diff/40001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/950813005/diff/40001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:58: // The list of possible
values for |messageType|.
Unrelated to this CL, but should these move too?

[jrummell, 2015-02-25 21:52:38]

Updated.

https://codereview.chromium.org/950813005/diff/40001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/950813005/diff/40001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:58: // The list of possible
values for |messageType|.
On 2015/02/25 21:38:51, ddorwin wrote:
> Unrelated to this CL, but should these move too?

Sure.

[ddorwin, 2015-02-25 22:20:10]

Thanks. LG

[jrummell, 2015-02-25 22:22:50]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2015-02-25 22:22:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org, haraken@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/950813005/#ps60001 (title:
"more contants removed")

[commit-bot: I haz the power, 2015-02-25 22:24:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950813005/60001

[jrummell, 2015-02-26 01:09:22]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2015-02-26 01:09:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dcheng@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/950813005/#ps80001 (title:
"android compile issues")

[commit-bot: I haz the power, 2015-02-26 01:09:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950813005/80001

[commit-bot: I haz the power, 2015-02-26 09:30:18]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190890