Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 950763002: Replace [TreatReturnedNullStringAs=Null] with nullable return type (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, arv+blink, vivekg_samsung, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, vivekg, dglazkov+blink, blink-reviews-dom_chromium.org, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace [TreatReturnedNullStringAs=Null] with nullable return type There are no changes to the generated code. One instance of TreatReturnedNullStringAs=Null remains for Node.textContent, where removing it does change the generated code because TreatUndefinedAs=NullString is also involved. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/css/MediaList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMSettableTokenList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTokenList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
PTAL. Apart from Node.textContent, TreatReturnedNullStringAs=Undefined is also used for Document.charset/defaultCharset/readyState. The easier way to get ...
5 years, 10 months ago (2015-02-23 08:04:07 UTC) #2
Jens Widell
LGTM
5 years, 10 months ago (2015-02-23 08:06:14 UTC) #3
haraken
LGTM Can we also remove TreatReturnedNullStringAs=Null from IDLExtendedAttributes.txt?
5 years, 10 months ago (2015-02-23 08:07:09 UTC) #4
philipj_slow
On 2015/02/23 08:07:09, haraken wrote: > LGTM > > Can we also remove TreatReturnedNullStringAs=Null from ...
5 years, 10 months ago (2015-02-23 08:30:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950763002/1
5 years, 10 months ago (2015-02-23 08:30:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190643
5 years, 10 months ago (2015-02-23 09:19:30 UTC) #8
philipj_slow
5 years, 6 months ago (2015-06-08 22:21:12 UTC) #9
Message was sent while issue was closed. 
On 2015/02/23 08:30:06, philipj wrote:
> On 2015/02/23 08:07:09, haraken wrote:
> > LGTM
> > 
> > Can we also remove TreatReturnedNullStringAs=Null from
> > IDLExtendedAttributes.txt?
> 
> TreatReturnedNullStringAs=Null is still used on Node.textContent.

It looks like it's in reach to get rid of [TreatReturnedNullStringAs] entirely
so I filed a bug:
https://code.google.com/p/chromium/issues/detail?id=497982

Powered by Google App Engine
This is Rietveld 408576698