Issue 950743002: Only compare unvisited background color for LayoutTheme adjustment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 950743002: Only compare unvisited background color for LayoutTheme adjustment (Closed)

Created:
5 years, 10 months ago by Timothy Loh

Modified:
5 years, 10 months ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Only compare unvisited background color for LayoutTheme adjustment This patch makes us compare unvisited background colors consistently when determining LayoutTheme adjustment. Previously CachedUAStyle would read out unvisited colors, while authorStyleInfo would read visited dependent colors. BUG=381808 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190632

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -2 lines)			Patch
A	LayoutTests/fast/history/visited-link-button.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/history/visited-link-button-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950743002/1

5 years, 10 months ago (2015-02-23 02:42:58 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 02:46:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190632

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages