Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: Source/modules/webmidi/MIDIAccessor.cpp

Issue 950643002: Web MIDI: complete blink API update to support MIDIPortState (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@midi_api_1
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIAccessor.h ('k') | public/platform/WebMIDIAccessorClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessor.cpp
diff --git a/Source/modules/webmidi/MIDIAccessor.cpp b/Source/modules/webmidi/MIDIAccessor.cpp
index be98c70449a12ed0f04837239bb54de3164dcd7c..5a69a571ea3e0292c9db9f20b7bc8505654b89a2 100644
--- a/Source/modules/webmidi/MIDIAccessor.cpp
+++ b/Source/modules/webmidi/MIDIAccessor.cpp
@@ -65,45 +65,27 @@ void MIDIAccessor::sendMIDIData(unsigned portIndex, const unsigned char* data, s
m_accessor->sendMIDIData(portIndex, data, length, timeStamp);
}
-// FIXME: Remove obsolete interfaces that use isActive.
-void MIDIAccessor::didAddInputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, bool isActive)
-{
- m_client->didAddInputPort(id, manufacturer, name, version, isActive);
-}
-
-void MIDIAccessor::didAddOutputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, bool isActive)
-{
- m_client->didAddOutputPort(id, manufacturer, name, version, isActive);
-}
-
void MIDIAccessor::didAddInputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, MIDIPortState state)
{
+ // FIXME: Update to support complete MIDIPortState in MIDIPort.
m_client->didAddInputPort(id, manufacturer, name, version, state != MIDIPortStateDisconnected);
}
void MIDIAccessor::didAddOutputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, MIDIPortState state)
{
+ // FIXME: Update to support complete MIDIPortState in MIDIPort.
m_client->didAddOutputPort(id, manufacturer, name, version, state != MIDIPortStateDisconnected);
}
-// FIXME: Remove obsolete interfaces that use isActive.
-void MIDIAccessor::didSetInputPortState(unsigned portIndex, bool isActive)
-{
- m_client->didSetInputPortState(portIndex, isActive);
-}
-
-void MIDIAccessor::didSetOutputPortState(unsigned portIndex, bool isActive)
-{
- m_client->didSetOutputPortState(portIndex, isActive);
-}
-
void MIDIAccessor::didSetInputPortState(unsigned portIndex, MIDIPortState state)
{
+ // FIXME: Update to support complete MIDIPortState in MIDIPort.
m_client->didSetInputPortState(portIndex, state != MIDIPortStateDisconnected);
}
void MIDIAccessor::didSetOutputPortState(unsigned portIndex, MIDIPortState state)
{
+ // FIXME: Update to support complete MIDIPortState in MIDIPort.
m_client->didSetOutputPortState(portIndex, state != MIDIPortStateDisconnected);
}
« no previous file with comments | « Source/modules/webmidi/MIDIAccessor.h ('k') | public/platform/WebMIDIAccessorClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698