Source/core/style/AppliedTextDecoration.cpp - Issue 950623002: Store resolved color in AppliedTextDecoration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/style/AppliedTextDecoration.cpp

Issue 950623002: Store resolved color in AppliedTextDecoration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed inherited_flags.m_textunderline Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/style/AppliedTextDecoration.cpp

diff --git a/Source/core/style/AppliedTextDecoration.cpp b/Source/core/style/AppliedTextDecoration.cpp

index a02ba11e0de84e1e39d6f70b6fffef2db21719ac..33d8672f3a5b57e23fe9244ce0265683c75c2250 100644

--- a/Source/core/style/AppliedTextDecoration.cpp

+++ b/Source/core/style/AppliedTextDecoration.cpp

@@ -7,17 +7,17 @@

namespace blink {

-AppliedTextDecoration::AppliedTextDecoration(TextDecoration line, TextDecorationStyle style, StyleColor color)

+AppliedTextDecoration::AppliedTextDecoration(TextDecoration line, TextDecorationStyle style, Color color)

: m_line(line)

, m_style(style)

, m_color(color)

{

}

-AppliedTextDecoration::AppliedTextDecoration(TextDecoration line)

- : m_line(line)

+AppliedTextDecoration::AppliedTextDecoration(TextDecoration decoration)

+ : m_line(decoration)

wkorman 2015/07/01 15:16:14 Should member data be renamed to suit?

, m_style(TextDecorationStyleSolid)

- , m_color(StyleColor::currentColor())

+ , m_color(Color::transparent)

{

}