Source/core/layout/LayoutObject.h - Issue 950623002: Store resolved color in AppliedTextDecoration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutObject.h

Issue 950623002: Store resolved color in AppliedTextDecoration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed inherited_flags.m_textunderline Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/text-decoration-color-on-hover.html ('K') | « Source/core/css/resolver/StyleAdjuster.cpp ('k') | Source/core/layout/LayoutObject.cpp » ('j') | Source/core/paint/InlineTextBoxPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutObject.h

diff --git a/Source/core/layout/LayoutObject.h b/Source/core/layout/LayoutObject.h

index dcf40cf01386ba07b5399dd8a9c6d8d46d8b1cfe..4e352d1e9761c7c59cb24288de8b2d301be6efb4 100644

--- a/Source/core/layout/LayoutObject.h

+++ b/Source/core/layout/LayoutObject.h

@@ -833,12 +833,6 @@ public:

virtual CursorDirective getCursor(const LayoutPoint&, Cursor&) const;

- struct AppliedTextDecoration {

- Color color;

- TextDecorationStyle style;

- AppliedTextDecoration() : color(Color::transparent), style(TextDecorationStyleSolid) { }

- };

void getTextDecorations(unsigned decorations, AppliedTextDecoration& underline, AppliedTextDecoration& overline, AppliedTextDecoration& linethrough, bool quirksMode = false, bool firstlineStyle = false);

// Return the LayoutBoxModelObject in the container chain which is responsible for painting this object, or 0