Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: LayoutTests/fast/css/text-decoration-color-on-hover.html

Issue 950623002: Store resolved color in AppliedTextDecoration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated patch with underline optimization handling Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css/text-decoration-color-on-hover.html
diff --git a/LayoutTests/fast/css/text-decoration-color-on-hover.html b/LayoutTests/fast/css/text-decoration-color-on-hover.html
new file mode 100644
index 0000000000000000000000000000000000000000..18734a92d4af93606e87476281059b15c3487445
--- /dev/null
+++ b/LayoutTests/fast/css/text-decoration-color-on-hover.html
@@ -0,0 +1,41 @@
+<!DOCTYPE html>
+<html>
+<head>
+<style>
+.outer {
+ text-decoration: underline;
+ color: blue;
+}
+
+.inner {
+ color: blue;
+}
+
+.nextouter{
+ text-decoration: underline;
+ color: red;
+}
+</style>
+</head>
+<body onload="setTimeout(change, 100)" >
+<p>
+ <span class=outer>
+ <span class=inner>
+ Hover me and then hover away
Timothy Loh 2015/03/25 00:26:23 There's no more hovering in this test. Just write
+ </span>
+ </span>
+</p>
+<script>
+if(window.testRunner)
+ testRunner.waitUntilDone();
Timothy Loh 2015/03/25 00:26:23 We shouldn't use a setTimeout. Just call outspan.o
samahto 2015/04/30 20:06:44 Tried the same(outspan.offsetTop trick) but its se
Timothy Loh 2015/05/04 00:35:15 Can we try using a requestAnimationFrame instead o
+
+function change() {
+ var outspan = document.getElementsByClassName("outer")[0];
+ outspan.className = "nextouter";
+
+ if(window.testRunner)
+ testRunner.notifyDone();
+}
+</script>
+</body>
+</html>
« no previous file with comments | « no previous file | LayoutTests/fast/css/text-decoration-color-on-hover-expected.html » ('j') | Source/core/layout/LayoutObject.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698