Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 950573002: Rename transform_converters.* to transform_type_converters.*. (Closed)

Created:
5 years, 10 months ago by wtc
Modified:
5 years, 10 months ago
Reviewers:
jamesr, msw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename transform_converters.* to transform_type_converters.*. These files declare/define mojo TypeConverters, so the file names should reflect that. R=jamesr@chromium.org,msw@chromium.org BUG=457280 Committed: https://crrev.com/6830d8f0dd0c9cb3b026ba1126525400be766792 Cr-Commit-Position: refs/heads/master@{#317619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -65 lines) Patch
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/transform/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/converters/transform/transform_converters.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/converters/transform/transform_converters.cc View 1 chunk +0 lines, -31 lines 0 comments Download
A + mojo/converters/transform/transform_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/converters/transform/transform_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
wtc
5 years, 10 months ago (2015-02-21 01:55:23 UTC) #1
jamesr
lgtm
5 years, 10 months ago (2015-02-23 19:07:11 UTC) #2
msw
lgtm
5 years, 10 months ago (2015-02-23 19:17:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950573002/1
5 years, 10 months ago (2015-02-23 19:18:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 19:22:15 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:22:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6830d8f0dd0c9cb3b026ba1126525400be766792
Cr-Commit-Position: refs/heads/master@{#317619}

Powered by Google App Engine
This is Rietveld 408576698