Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 950553002: Address TODOs in the new layer painting and hit testing. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Address TODOs in the new layer painting and hit testing. -ASSERT(layer()->parent()) in all the transform codepaths since the RenderView cannot have a transform. -Early return if the content rect does not intersect the damage rect in the painting code. We don't need to do any of the filter and/or transparency dance if we're not going to paint anything. This also allowed for removing the shouldPaintContent bool. -Remove a random style() null check that can't be hit. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c27c5e71f7b47b1c797107dc4e04e0b9dca033d5

Patch Set 1 #

Patch Set 2 : remove shouldClip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -59 lines) Patch
M sky/engine/core/rendering/RenderBox.cpp View 1 8 chunks +45 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-21 02:10:38 UTC) #2
ojan
5 years, 10 months ago (2015-02-21 02:19:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c27c5e71f7b47b1c797107dc4e04e0b9dca033d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698