Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/hydrogen.cc

Issue 95053002: Fix allocation memento bookeeping code for js arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2230 matching lines...) Expand 10 before | Expand all | Expand 10 after
2241 JSArray::kSize, 2241 JSArray::kSize,
2242 allocation_site_payload); 2242 allocation_site_payload);
2243 if (FLAG_allocation_site_pretenuring) { 2243 if (FLAG_allocation_site_pretenuring) {
2244 // TODO(mvstanton): move this code into BuildCreateAllocationMemento when 2244 // TODO(mvstanton): move this code into BuildCreateAllocationMemento when
2245 // constructed arrays also pay attention to pretenuring. 2245 // constructed arrays also pay attention to pretenuring.
2246 HObjectAccess access = 2246 HObjectAccess access =
2247 HObjectAccess::ForAllocationSiteOffset( 2247 HObjectAccess::ForAllocationSiteOffset(
2248 AllocationSite::kMementoCreateCountOffset); 2248 AllocationSite::kMementoCreateCountOffset);
2249 HValue* create_info = Add<HLoadNamedField>(allocation_site_payload, 2249 HValue* create_info = Add<HLoadNamedField>(allocation_site_payload,
2250 access); 2250 access);
2251 HInstruction* new_create_info = HAdd::New(zone(), context(), 2251 HInstruction* new_create_info =
2252 create_info, 2252 AddUncasted<HAdd>(create_info, graph()->GetConstant1());
2253 graph()->GetConstant1());
2254 new_create_info->ClearFlag(HValue::kCanOverflow); 2253 new_create_info->ClearFlag(HValue::kCanOverflow);
2255 HStoreNamedField* store = Add<HStoreNamedField>(allocation_site_payload, 2254 HStoreNamedField* store = Add<HStoreNamedField>(allocation_site_payload,
2256 access, new_create_info); 2255 access, new_create_info);
2257 // No write barrier needed to store a smi. 2256 // No write barrier needed to store a smi.
2258 store->SkipWriteBarrier(); 2257 store->SkipWriteBarrier();
2259 } 2258 }
2260 } 2259 }
2261 2260
2262 int elements_location = JSArray::kSize; 2261 int elements_location = JSArray::kSize;
2263 if (mode == TRACK_ALLOCATION_SITE) { 2262 if (mode == TRACK_ALLOCATION_SITE) {
(...skipping 8550 matching lines...) Expand 10 before | Expand all | Expand 10 after
10814 if (ShouldProduceTraceOutput()) { 10813 if (ShouldProduceTraceOutput()) {
10815 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 10814 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
10816 } 10815 }
10817 10816
10818 #ifdef DEBUG 10817 #ifdef DEBUG
10819 graph_->Verify(false); // No full verify. 10818 graph_->Verify(false); // No full verify.
10820 #endif 10819 #endif
10821 } 10820 }
10822 10821
10823 } } // namespace v8::internal 10822 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698