Fix a crash when processing an invalid PAC script.

net/proxy/proxy_resolver_v8_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 235 matching lines @@
 TEST(ProxyResolverV8Test, NoEntryPoint) {
   ProxyResolverV8WithMockBindings resolver;
   int result = resolver.SetPacScriptFromDisk("no_entrypoint.js");
   EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result);
 
   ProxyInfo proxy_info;
   result = resolver.GetProxyForURL(
       kQueryUrl, &proxy_info, CompletionCallback(), NULL, BoundNetLog());
 
   EXPECT_EQ(ERR_FAILED, result);
+
+  MockJSBindings* bindings = resolver.mock_js_bindings();
+  ASSERT_EQ(1U, bindings->errors.size());
+  EXPECT_EQ("FindProxyForURL is undefined or not a function.",
+            bindings->errors[0]);
+  EXPECT_EQ(-1, bindings->errors_line_number[0]);
 }
 
 // Try loading a malformed PAC script.
 TEST(ProxyResolverV8Test, ParseError) {
   ProxyResolverV8WithMockBindings resolver;
   int result = resolver.SetPacScriptFromDisk("missing_close_brace.js");
   EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result);
 
   ProxyInfo proxy_info;
   result = resolver.GetProxyForURL(
@@ skipping 55 matching lines @@
   EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result);
 
   MockJSBindings* bindings = resolver.mock_js_bindings();
   EXPECT_EQ(0U, bindings->alerts.size());
   ASSERT_EQ(1U, bindings->errors.size());
   EXPECT_EQ("Uncaught ReferenceError: undefined_variable is not defined",
             bindings->errors[0]);
   EXPECT_EQ(3, bindings->errors_line_number[0]);
 }
 
+// Execute a PAC script which throws an exception when first accessing
+// FindProxyForURL
+TEST(ProxyResolverV8Test, ExceptionAccessingFindProxyForURLDuringInit) {
+  ProxyResolverV8WithMockBindings resolver;
+  int result =
+      resolver.SetPacScriptFromDisk("exception_findproxyforurl_during_init.js");
+  EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result);
+
+  MockJSBindings* bindings = resolver.mock_js_bindings();
+  ASSERT_EQ(2U, bindings->errors.size());
+  EXPECT_EQ("Uncaught crash!", bindings->errors[0]);
+  EXPECT_EQ("Accessing FindProxyForURL threw an exception.",
+            bindings->errors[1]);
+}
+
+// Execute a PAC script which throws an exception during the second access to
+// FindProxyForURL
+TEST(ProxyResolverV8Test, ExceptionAccessingFindProxyForURLDuringResolve) {
+  ProxyResolverV8WithMockBindings resolver;
+  int result = resolver.SetPacScriptFromDisk(
+      "exception_findproxyforurl_during_resolve.js");
+  EXPECT_EQ(OK, result);
+
+  ProxyInfo proxy_info;
+  result = resolver.GetProxyForURL(kQueryUrl, &proxy_info, CompletionCallback(),
+                                   NULL, BoundNetLog());
+
+  EXPECT_EQ(ERR_PAC_SCRIPT_FAILED, result);
+
+  MockJSBindings* bindings = resolver.mock_js_bindings();
+  ASSERT_EQ(2U, bindings->errors.size());
+  EXPECT_EQ("Uncaught crash!", bindings->errors[0]);
+  EXPECT_EQ("Accessing FindProxyForURL threw an exception.",
+            bindings->errors[1]);
+}
+
 TEST(ProxyResolverV8Test, ReturnUnicode) {
   ProxyResolverV8WithMockBindings resolver;
   int result = resolver.SetPacScriptFromDisk("return_unicode.js");
   EXPECT_EQ(OK, result);
 
   ProxyInfo proxy_info;
   result = resolver.GetProxyForURL(
       kQueryUrl, &proxy_info, CompletionCallback(), NULL, BoundNetLog());
 
   // The result from this resolve was unparseable, because it
@@ skipping 275 matching lines @@
       GURL("http://kittens/"), &proxy_info,
       CompletionCallback(), NULL, BoundNetLog());
 
   EXPECT_EQ(OK, result);
   EXPECT_EQ(0u, bindings->errors.size());
   EXPECT_EQ("kittens:88", proxy_info.proxy_server().ToURI());
 }
 
 }  // namespace
 }  // namespace net