Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: net/data/proxy_resolver_v8_unittest/exception_findproxyforurl_during_resolve.js

Issue 950433002: Fix a crash when processing an invalid PAC script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback from mmenke Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // This PAC script will throw an exception when accessing the "FindProxyForURL"
2 // the *second* time it is accessed.
3
4 function actualFindProxyForURL(url, host) {
5 return "DIRECT";
6 }
7
8 var counter = 2;
9
10 function FindProxyForURLGetter() {
mmenke 2015/02/20 22:15:05 nit: f should be lowercase, I believe.
11 counter--;
12 if (counter <= 0)
13 throw "crash!";
14 return actualFindProxyForURL;
15 }
16
17 Object.defineProperty(this, "FindProxyForURL", {get: FindProxyForURLGetter});
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698