content/browser/service_worker/service_worker_storage.cc - Issue 950343006: [BackgroundSync] Initial land of the BackgroundSyncManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.cc

Issue 950343006: [BackgroundSync] Initial land of the BackgroundSyncManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mapped registrations, more tests, register overwrites existing, unique ids for registrations Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/background_sync/background_sync_manager_unittest.cc ('K') | « content/browser/service_worker/service_worker_storage.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage.cc

diff --git a/content/browser/service_worker/service_worker_storage.cc b/content/browser/service_worker/service_worker_storage.cc

index 9ae8c513df64a17ece0945c29883459be802ebac..c7fa413ea17f34d92b524e69f7b564a05bfdf39e 100644

--- a/content/browser/service_worker/service_worker_storage.cc

+++ b/content/browser/service_worker/service_worker_storage.cc

@@ -773,13 +773,17 @@ void ServiceWorkerStorage::GetUserDataForAllRegistrations(

const std::string& key,

const ServiceWorkerStorage::GetUserDataForAllRegistrationsCallback&

callback) {

- DCHECK(state_ == INITIALIZED || state_ == DISABLED) << state_;

- if (IsDisabled() || !context_) {

- RunSoon(FROM_HERE,

- base::Bind(callback, std::vector<std::pair<int64, std::string>>(),

- SERVICE_WORKER_ERROR_FAILED));

+ if (!LazyInitialize(

+ base::Bind(&ServiceWorkerStorage::GetUserDataForAllRegistrations,

+ weak_factory_.GetWeakPtr(), key, callback))) {

+ if (state_ != INITIALIZING || !context_) {

+ RunSoon(FROM_HERE,

+ base::Bind(callback, std::vector<std::pair<int64, std::string>>(),

+ SERVICE_WORKER_ERROR_FAILED));

+ }

return;

}

+ DCHECK_EQ(INITIALIZED, state_);

if (key.empty()) {

RunSoon(FROM_HERE,