Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 950343005: Improve webaudio/audiocontext-close.html stability. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
haraken, Raymond Toy
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve webaudio/audiocontext-close.html stability. Scheduling the post-GC testing via a timeout handler runs the risk of the test completing before the test completes. No need for the GC to be async here; simplify accordingly to avoid the timing issue. R=haraken BUG=461762 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M LayoutTests/webaudio/audiocontext-close.html View 7 chunks +19 lines, -27 lines 0 comments Download
M LayoutTests/webaudio/audiocontext-close-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. Without this the shouldBeNull() test only runs sometimes, leading to curious ...
5 years, 10 months ago (2015-02-25 10:47:15 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-25 11:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343005/1
5 years, 10 months ago (2015-02-25 11:41:45 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 12:06:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190825

Powered by Google App Engine
This is Rietveld 408576698