Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 950343004: Update V8 DEPS. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update V8 DEPS. Rolling v8/third_party/icu to eda9e75b1fa17f57ffa369ee3543a2301b68d0a9 TBR=jochen@chromium.org Committed: https://crrev.com/c11c0bdbeda573640400cd01ff9f9cbcf33390df Cr-Commit-Position: refs/heads/master@{#26999}

Patch Set 1 #

Patch Set 2 : Rebase after https://codereview.chromium.org/972953002/ #

Patch Set 3 : Newest ICU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/get_landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (8 generated)
Michael Achenbach
PTAL. Copy of https://codereview.chromium.org/945703002/ with a landmine.
5 years, 10 months ago (2015-02-24 18:11:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/1
5 years, 10 months ago (2015-02-24 18:12:21 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/217)
5 years, 10 months ago (2015-02-24 18:15:23 UTC) #6
Michael Achenbach
Meh - look like landmines only work when the .landmines file already exists. Since the ...
5 years, 10 months ago (2015-02-24 19:08:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/1
5 years, 10 months ago (2015-02-25 09:42:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/3343)
5 years, 10 months ago (2015-02-25 09:45:46 UTC) #11
Michael Achenbach
Meh2 - the directory names within the xcodebuild dir are different than *release* and *debug*. ...
5 years, 10 months ago (2015-02-25 09:57:02 UTC) #12
Michael Achenbach
Meh3 - also the msvs project files aren't recreated correctly. And the soft clobber doesn't ...
5 years, 10 months ago (2015-02-25 14:49:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/1
5 years, 10 months ago (2015-02-26 12:48:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/3400)
5 years, 10 months ago (2015-02-26 13:02:18 UTC) #17
Michael Achenbach
Meh4 - windows is still screwed :(
5 years, 9 months ago (2015-03-04 13:51:08 UTC) #18
Michael Achenbach
FYI jshin@chromium.org
5 years, 9 months ago (2015-03-04 13:52:12 UTC) #19
jochen (gone - plz use gerrit)
i think the windows dll was committe after the icu roll, so we'd need to ...
5 years, 9 months ago (2015-03-04 13:58:06 UTC) #20
Michael Achenbach
You're right! On it...
5 years, 9 months ago (2015-03-04 14:16:18 UTC) #21
Michael Achenbach
That worked. I wait for the chromium counterpart to land and then I commit this.
5 years, 9 months ago (2015-03-04 14:41:20 UTC) #22
jungshik at Google
On 2015/03/04 14:41:20, Michael Achenbach wrote: > That worked. I wait for the chromium counterpart ...
5 years, 9 months ago (2015-03-04 18:33:17 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/40001
5 years, 9 months ago (2015-03-04 19:44:27 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 19:45:36 UTC) #26
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:45:53 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c11c0bdbeda573640400cd01ff9f9cbcf33390df
Cr-Commit-Position: refs/heads/master@{#26999}

Powered by Google App Engine
This is Rietveld 408576698