|
|
Created:
5 years, 10 months ago by Michael Achenbach Modified:
5 years, 9 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionUpdate V8 DEPS.
Rolling v8/third_party/icu to eda9e75b1fa17f57ffa369ee3543a2301b68d0a9
TBR=jochen@chromium.org
Committed: https://crrev.com/c11c0bdbeda573640400cd01ff9f9cbcf33390df
Cr-Commit-Position: refs/heads/master@{#26999}
Patch Set 1 #Patch Set 2 : Rebase after https://codereview.chromium.org/972953002/ #Patch Set 3 : Newest ICU #Messages
Total messages: 27 (8 generated)
machenbach@chromium.org changed reviewers: + jochen@chromium.org
PTAL. Copy of https://codereview.chromium.org/945703002/ with a landmine.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
Meh - look like landmines only work when the .landmines file already exists. Since the landmines CL just landed it doesn't on most of the slaves...
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/3343)
Meh2 - the directory names within the xcodebuild dir are different than *release* and *debug*. Will make the landmines script slightly harder again.
Meh3 - also the msvs project files aren't recreated correctly. And the soft clobber doesn't delete them on windows. Now I probably have to go down the stony road...
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/3400)
Meh4 - windows is still screwed :(
i think the windows dll was committe after the icu roll, so we'd need to roll chromium again
You're right! On it...
That worked. I wait for the chromium counterpart to land and then I commit this.
On 2015/03/04 14:41:20, Michael Achenbach wrote: > That worked. I wait for the chromium counterpart to land and then I commit this. Yeah. I had to sort out "mo" display name. It's https://codereview.chromium.org/971653005/
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/950343004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c11c0bdbeda573640400cd01ff9f9cbcf33390df Cr-Commit-Position: refs/heads/master@{#26999} |