Use mutex/condition variables to synchronize threads

src/optimizing-compiler-thread.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/optimizing-compiler-thread.h"
 
 #include "src/v8.h"
 
 #include "src/base/atomicops.h"
 #include "src/full-codegen.h"
@@ skipping 25 matching lines @@
   }
   delete info;
 }
 
 }  // namespace
 
 
 class OptimizingCompilerThread::CompileTask : public v8::Task {
  public:
   explicit CompileTask(Isolate* isolate) : isolate_(isolate) {
-    base::NoBarrier_AtomicIncrement(
-        &isolate_->optimizing_compiler_thread()->ref_count_, 1);
+    OptimizingCompilerThread* thread = isolate_->optimizing_compiler_thread();
+    base::LockGuard<base::Mutex> lock_guard(&thread->ref_count_mutex_);
+    ++thread->ref_count_;
   }
 
   virtual ~CompileTask() {}
 
  private:
   // v8::Task overrides.
   void Run() OVERRIDE {
     DisallowHeapAllocation no_allocation;
     DisallowHandleAllocation no_handles;
     DisallowHandleDereference no_deref;
 
     OptimizingCompilerThread* thread = isolate_->optimizing_compiler_thread();
-    StopFlag flag = CONTINUE;
-
     {
       TimerEventScope<TimerEventRecompileConcurrent> timer(isolate_);
 
       if (thread->recompilation_delay_ != 0) {
         base::OS::Sleep(thread->recompilation_delay_);
       }
 
-      OptimizedCompileJob* job = thread->NextInput(&flag);
-
-      switch (flag) {
-        case CONTINUE:
-          thread->CompileNext(job);
-          break;
-
-        case STOP:
-        case FLUSH: {
-          AllowHandleDereference allow_handle_dereference;
-          if (!job->info()->is_osr()) {
-            DisposeOptimizedCompileJob(job, true);
-          }
-          break;
-        }
+      thread->CompileNext(thread->NextInput(true));
+    }
+    {
+      base::LockGuard<base::Mutex> lock_guard(&thread->ref_count_mutex_);
+      if (--thread->ref_count_ == 0) {
+        thread->ref_count_zero_.NotifyOne();
       }
     }
-    if (flag == STOP) {
-      base::Release_Store(&thread->stop_thread_,
-                          static_cast<base::AtomicWord>(CONTINUE));
-      thread->stop_semaphore_.Signal();
-    }
-
-    if (base::NoBarrier_AtomicIncrement(&thread->ref_count_, -1) == 0) {
-      thread->stop_semaphore_.Signal();
-    }
   }
 
   Isolate* isolate_;
 
   DISALLOW_COPY_AND_ASSIGN(CompileTask);
 };
 
 
 OptimizingCompilerThread::~OptimizingCompilerThread() {
-  if (base::NoBarrier_AtomicIncrement(&ref_count_, -1) > 0) {
-    stop_semaphore_.Wait();
+#ifdef DEBUG
+  {
+    base::LockGuard<base::Mutex> lock_guard(&ref_count_mutex_);
+    DCHECK_EQ(0, ref_count_);
   }
+#endif
   DCHECK_EQ(0, input_queue_length_);
   DeleteArray(input_queue_);
   if (FLAG_concurrent_osr) {
 #ifdef DEBUG
     for (int i = 0; i < osr_buffer_capacity_; i++) {
       CHECK_NULL(osr_buffer_[i]);
     }
 #endif
     DeleteArray(osr_buffer_);
   }
@@ skipping 51 matching lines @@
 
     CompileNext(NextInput());
 
     if (tracing_enabled_) {
       time_spent_compiling_ += compiling_timer.Elapsed();
     }
   }
 }
 
 
-OptimizedCompileJob* OptimizingCompilerThread::NextInput(StopFlag* flag) {
+OptimizedCompileJob* OptimizingCompilerThread::NextInput(
+    bool check_if_flushing) {
   base::LockGuard<base::Mutex> access_input_queue_(&input_queue_mutex_);
-  if (input_queue_length_ == 0) {
-    if (flag) {
-      UNREACHABLE();
-      *flag = CONTINUE;
-    }
-    return NULL;
-  }
+  if (input_queue_length_ == 0) return NULL;
   OptimizedCompileJob* job = input_queue_[InputQueueIndex(0)];
   DCHECK_NOT_NULL(job);
   input_queue_shift_ = InputQueueIndex(1);
   input_queue_length_--;
-  if (flag) {
-    switch (static_cast<StopFlag>(base::Acquire_Load(&stop_thread_))) {
-      case CONTINUE:
-        *flag = CONTINUE;
-        break;
-
-      case FLUSH:
-        if (input_queue_length_ == 0) {
-          *flag = STOP;
-        } else {
-          *flag = FLUSH;
-        }
-        break;
-
-      case STOP:
-        UNREACHABLE();
-        *flag = CONTINUE;
-        break;
+  if (check_if_flushing) {
+    if (static_cast<StopFlag>(base::Acquire_Load(&stop_thread_)) != CONTINUE) {
+      if (!job->info()->is_osr()) DisposeOptimizedCompileJob(job, true);
+      return NULL;
     }
   }
   return job;
 }
 
 
 void OptimizingCompilerThread::CompileNext(OptimizedCompileJob* job) {
-  DCHECK_NOT_NULL(job);
+  if (!job) return;
 
   // The function may have already been optimized by OSR.  Simply continue.
   OptimizedCompileJob::Status status = job->OptimizeGraph();
   USE(status);   // Prevent an unused-variable error in release mode.
   DCHECK(status != OptimizedCompileJob::FAILED);
 
   // The function may have already been optimized by OSR.  Simply continue.
   // Use a mutex to make sure that functions marked for install
   // are always also queued.
   if (job_based_recompilation_) output_queue_mutex_.Lock();
@@ skipping 35 matching lines @@
     if (osr_buffer_[i] != NULL) {
       DisposeOptimizedCompileJob(osr_buffer_[i], restore_function_code);
       osr_buffer_[i] = NULL;
     }
   }
 }
 
 
 void OptimizingCompilerThread::Flush() {
   DCHECK(!IsOptimizerThread());
-  bool block = true;
-  if (job_based_recompilation_) {
-    if (FLAG_block_concurrent_recompilation) Unblock();
-    {
-      base::LockGuard<base::Mutex> lock(&input_queue_mutex_);
-      block = input_queue_length_ > 0;
-      if (block) {
-        base::Release_Store(&stop_thread_,
-                            static_cast<base::AtomicWord>(FLUSH));
-      }
-    }
+  base::Release_Store(&stop_thread_, static_cast<base::AtomicWord>(FLUSH));
+  if (FLAG_block_concurrent_recompilation) Unblock();
+  if (!job_based_recompilation_) {
+    input_queue_semaphore_.Signal();
+    stop_semaphore_.Wait();
   } else {
-    base::Release_Store(&stop_thread_, static_cast<base::AtomicWord>(FLUSH));
-    if (FLAG_block_concurrent_recompilation) Unblock();
+    base::LockGuard<base::Mutex> lock_guard(&ref_count_mutex_);
+    while (ref_count_ > 0) ref_count_zero_.Wait(&ref_count_mutex_);
+    base::Release_Store(&stop_thread_, static_cast<base::AtomicWord>(CONTINUE));
   }
-  if (!job_based_recompilation_) input_queue_semaphore_.Signal();
-  if (block) stop_semaphore_.Wait();
   FlushOutputQueue(true);
   if (FLAG_concurrent_osr) FlushOsrBuffer(true);
   if (tracing_enabled_) {
     PrintF("  ** Flushed concurrent recompilation queues.\n");
   }
 }
 
 
 void OptimizingCompilerThread::Stop() {
   DCHECK(!IsOptimizerThread());
-  bool block = true;
-  if (job_based_recompilation_) {
-    if (FLAG_block_concurrent_recompilation) Unblock();
-    {
-      base::LockGuard<base::Mutex> lock(&input_queue_mutex_);
-      block = input_queue_length_ > 0;
-      if (block) {
-        base::Release_Store(&stop_thread_,
-                            static_cast<base::AtomicWord>(FLUSH));
-      }
-    }
+  base::Release_Store(&stop_thread_, static_cast<base::AtomicWord>(STOP));
+  if (FLAG_block_concurrent_recompilation) Unblock();
+  if (!job_based_recompilation_) {
+    input_queue_semaphore_.Signal();
+    stop_semaphore_.Wait();
   } else {
-    base::Release_Store(&stop_thread_, static_cast<base::AtomicWord>(STOP));
-    if (FLAG_block_concurrent_recompilation) Unblock();
+    base::LockGuard<base::Mutex> lock_guard(&ref_count_mutex_);
+    while (ref_count_ > 0) ref_count_zero_.Wait(&ref_count_mutex_);
+    base::Release_Store(&stop_thread_, static_cast<base::AtomicWord>(CONTINUE));
   }
-  if (!job_based_recompilation_) input_queue_semaphore_.Signal();
-  if (block) stop_semaphore_.Wait();
 
   if (recompilation_delay_ != 0) {
     // At this point the optimizing compiler thread's event loop has stopped.
     // There is no need for a mutex when reading input_queue_length_.
     while (input_queue_length_ > 0) CompileNext(NextInput());
     InstallOptimizedFunctions();
   } else {
     FlushInputQueue(false);
     FlushOutputQueue(false);
   }
@@ skipping 175 matching lines @@
 
 
 bool OptimizingCompilerThread::IsOptimizerThread() {
   base::LockGuard<base::Mutex> lock_guard(&thread_id_mutex_);
   return ThreadId::Current().ToInteger() == thread_id_;
 }
 #endif
 
 
 } }  // namespace v8::internal