src/x64/full-codegen-x64.cc - Issue 950283002: Move Maps' back pointers from "transitions" to "constructor" field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 950283002: Move Maps' back pointers from "transitions" to "constructor" field (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix stupidity on arm64 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index faf9e74dcf3a66e4be499e655ef6915ab816ff91..a5b065289d829a1f9b5fbe23399433c0cd04eaca 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -3666,8 +3666,8 @@ void FullCodeGenerator::EmitClassOf(CallRuntime* expr) {

STATIC_ASSERT(LAST_NONCALLABLE_SPEC_OBJECT_TYPE == LAST_TYPE - 1);

// Check if the constructor in the map is a JS function.

- __ movp(rax, FieldOperand(rax, Map::kConstructorOffset));

- __ CmpObjectType(rax, JS_FUNCTION_TYPE, rbx);

+ __ GetMapConstructor(rax, rax, rbx);

+ __ CmpInstanceType(rbx, JS_FUNCTION_TYPE);

__ j(not_equal, &non_function_constructor);

// rax now contains the constructor function. Grab the

« no previous file with comments | « src/type-info.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »