src/arm/full-codegen-arm.cc - Issue 950283002: Move Maps' back pointers from "transitions" to "constructor" field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 950283002: Move Maps' back pointers from "transitions" to "constructor" field (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix stupidity on arm64 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index 15958ccf54561149055489f32188e1530473fb81..f433990d23a9b41c171c1fc9e987dbe004730ed7 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -3777,8 +3777,9 @@ void FullCodeGenerator::EmitClassOf(CallRuntime* expr) {

STATIC_ASSERT(LAST_NONCALLABLE_SPEC_OBJECT_TYPE == LAST_TYPE - 1);

// Check if the constructor in the map is a JS function.

- __ ldr(r0, FieldMemOperand(r0, Map::kConstructorOffset));

- __ CompareObjectType(r0, r1, r1, JS_FUNCTION_TYPE);

+ Register instance_type = r2;

+ __ GetMapConstructor(r0, r0, r1, instance_type);

+ __ cmp(instance_type, Operand(JS_FUNCTION_TYPE));

__ b(ne, &non_function_constructor);

// r0 now contains the constructor function. Grab the

« no previous file with comments | « src/api.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »