Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: src/builtins.cc

Issue 950283002: Move Maps' back pointers from "transitions" to "constructor" field (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix stupidity on arm64 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 1167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 Heap* heap = isolate->heap(); 1178 Heap* heap = isolate->heap();
1179 1179
1180 Handle<Object> receiver = args.receiver(); 1180 Handle<Object> receiver = args.receiver();
1181 1181
1182 // Get the object called. 1182 // Get the object called.
1183 JSObject* obj = JSObject::cast(*receiver); 1183 JSObject* obj = JSObject::cast(*receiver);
1184 1184
1185 // Get the invocation callback from the function descriptor that was 1185 // Get the invocation callback from the function descriptor that was
1186 // used to create the called object. 1186 // used to create the called object.
1187 DCHECK(obj->map()->has_instance_call_handler()); 1187 DCHECK(obj->map()->has_instance_call_handler());
1188 JSFunction* constructor = JSFunction::cast(obj->map()->constructor()); 1188 JSFunction* constructor = JSFunction::cast(obj->map()->GetConstructor());
1189 // TODO(ishell): turn this back to a DCHECK. 1189 // TODO(ishell): turn this back to a DCHECK.
1190 CHECK(constructor->shared()->IsApiFunction()); 1190 CHECK(constructor->shared()->IsApiFunction());
1191 Object* handler = 1191 Object* handler =
1192 constructor->shared()->get_api_func_data()->instance_call_handler(); 1192 constructor->shared()->get_api_func_data()->instance_call_handler();
1193 DCHECK(!handler->IsUndefined()); 1193 DCHECK(!handler->IsUndefined());
1194 // TODO(ishell): remove this debugging code. 1194 // TODO(ishell): remove this debugging code.
1195 CHECK(handler->IsCallHandlerInfo()); 1195 CHECK(handler->IsCallHandlerInfo());
1196 CallHandlerInfo* call_data = CallHandlerInfo::cast(handler); 1196 CallHandlerInfo* call_data = CallHandlerInfo::cast(handler);
1197 Object* callback_obj = call_data->callback(); 1197 Object* callback_obj = call_data->callback();
1198 v8::FunctionCallback callback = 1198 v8::FunctionCallback callback =
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
1640 } 1640 }
1641 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C) 1641 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
1642 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A) 1642 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
1643 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 1643 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
1644 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 1644 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
1645 #undef DEFINE_BUILTIN_ACCESSOR_C 1645 #undef DEFINE_BUILTIN_ACCESSOR_C
1646 #undef DEFINE_BUILTIN_ACCESSOR_A 1646 #undef DEFINE_BUILTIN_ACCESSOR_A
1647 1647
1648 1648
1649 } } // namespace v8::internal 1649 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698