Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 950223006: Fix RenderFrameHostChanged WebContentsObserver methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Charlie's review. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 15338be2d0de70f6d680a0daf3b0359aa460b58d..073908ad44cf1b497b062b96ec6b18ebf4529ef9 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -137,6 +137,11 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
virtual void NotifySwappedFromRenderManager(RenderFrameHost* old_host,
RenderFrameHost* new_host,
bool is_main_frame) = 0;
+ // TODO(nasko): This should be removed once extensions no longer use
+ // NotificationService. See https://crbug.com/462682.
+ virtual void NotifyMainFrameSwappedFromRenderManager(
+ RenderViewHost* old_host,
+ RenderViewHost* new_host) = 0;
virtual NavigationControllerImpl&
GetControllerForRenderManager() = 0;
« no previous file with comments | « content/browser/frame_host/frame_tree_unittest.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698