Android: Move resources for validation message bubble to components/web_contents_delegate_android/.

Android: Move resources for validation message bubble to components/web_contents_delegate_android/.

These resources are used only by web_contents_delegate_android.

BUG=458328
Committed: https://crrev.com/6a885cd9038c536a3c7c13f0ca99eb8e59dcc75e
Cr-Commit-Position: refs/heads/master@{#318637}

[tkent, 2015-02-24 06:06:18]

Patchset #2 (id:20001) has been deleted

[tkent, 2015-02-24 06:07:44]

tkent@chromium.org changed reviewers:
+ aurimas@chromium.org, benm@chromium.org

[tkent, 2015-02-24 06:07:46]

aurimas, benm, the patch doesn't work for android_aosp.  What should we do for
it?

[benm (inactive), 2015-02-24 11:25:50]

benm@chromium.org changed reviewers:
+ torne@chromium.org

[benm (inactive), 2015-02-24 11:25:50]

+torne

[Torne, 2015-02-24 12:44:43]

I think you need to add a new action to the list here:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/an...

which will jarjar the resources from this new res/ directory, and then add an
entry to the list of inputs here:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/bu...

to actually include the resources in the webview APK.

[tkent, 2015-02-25 00:48:30]

Patchset #2 (id:40001) has been deleted

[tkent, 2015-02-25 06:09:03]

On 2015/02/24 12:44:43, Torne wrote:
> I think you need to add a new action to the list here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/an...
> 
> which will jarjar the resources from this new res/ directory, and then add an
> entry to the list of inputs here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/bu...
> 
> to actually include the resources in the webview APK.

Thank you for the advice.  I followed it in Patch Set 2, but still have the same
build error.

[Torne, 2015-02-25 09:30:33]

On 2015/02/25 06:09:03, tkent wrote:
> On 2015/02/24 12:44:43, Torne wrote:
> > I think you need to add a new action to the list here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/an...
> > 
> > which will jarjar the resources from this new res/ directory, and then add
an
> > entry to the list of inputs here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/bu...
> > 
> > to actually include the resources in the webview APK.
> 
> Thank you for the advice.  I followed it in Patch Set 2, but still have the
same
> build error.

Hm. I think you also need to add "--extra-packages
org.chromium.components.web_contents_delegate_android" to the list of those in
android_webview_aapt_flags in resources_config.mk too.

Sorry about this, the people who got a lot of this stuff working on the aosp bot
are no longer on the team. We're hoping we can get rid of the whole android_aosp
bot pretty soon :)

[tkent, 2015-02-25 23:37:53]

Patchset #3 (id:80001) has been deleted

[tkent, 2015-02-26 01:15:55]

On 2015/02/25 09:30:33, Torne wrote:
> Hm. I think you also need to add "--extra-packages
> org.chromium.components.web_contents_delegate_android" to the list of those in
> android_webview_aapt_flags in resources_config.mk too.

Thank you!  Try bots finally passed.

[aurimas (slooooooooow), 2015-02-26 01:16:58]

lgtm

[Torne, 2015-02-26 10:25:35]

android_webview/ LGTM

[aurimas (slooooooooow), 2015-02-26 23:16:55]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-02-26 23:16:55]

+tedchoc@ as benm@ no longer works on Chrome.

[Ted C, 2015-02-26 23:20:54]

On 2015/02/26 23:16:55, aurimas wrote:
> +tedchoc@ as benm@ no longer works on Chrome.

lgtm

[aurimas (slooooooooow), 2015-02-26 23:23:55]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-02-26 23:25:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950223002/100001

[commit-bot: I haz the power, 2015-02-27 01:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-27 01:22:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2015-02-27 01:28:42]

tkent@chromium.org changed reviewers:
+ jochen@chromium.org

[tkent, 2015-02-27 01:28:42]

jochen, would you stamp components/web_contents_delegate_android.gypi change
please?
It has no per-file owner.

[jochen (gone - plz use gerrit), 2015-02-27 09:10:34]

On 2015/02/27 at 01:28:42, tkent wrote:
> jochen, would you stamp components/web_contents_delegate_android.gypi change
please?
> It has no per-file owner.

could you add an appropriate per-file OWNER please?

then this lgtm

[tkent, 2015-03-01 23:34:06]

On 2015/02/27 09:10:34, jochen (traveling) wrote:
> On 2015/02/27 at 01:28:42, tkent wrote:
> > jochen, would you stamp components/web_contents_delegate_android.gypi change
> please?
> > It has no per-file owner.
> 
> could you add an appropriate per-file OWNER please?
> 
> then this lgtm

Done.
I added:

> per-file web_contents_delegate_android.gypi=benm@chromium.org
> per-file web_contents_delegate_android.gypi=tedchoc@chromium.org

[tkent, 2015-03-01 23:34:11]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-03-01 23:34:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, aurimas@chromium.org, jochen@chromium.org,
torne@chromium.org
Link to the patchset: https://codereview.chromium.org/950223002/#ps120001
(title: "add per-file entries")

[commit-bot: I haz the power, 2015-03-01 23:34:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950223002/120001

[commit-bot: I haz the power, 2015-03-01 23:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-01 23:43:38]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[tkent, 2015-03-02 01:51:09]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-03-02 01:51:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950223002/120001

[commit-bot: I haz the power, 2015-03-02 03:05:56]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-03-02 03:07:29]

Patchset 4 (id:??) landed as
https://crrev.com/6a885cd9038c536a3c7c13f0ca99eb8e59dcc75e
Cr-Commit-Position: refs/heads/master@{#318637}