Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 95013004: Make consistent with Accelerated 2D Canvas flag on both implementation and chrome://gpu. (Closed)

Created:
7 years ago by dshwang
Modified:
7 years ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make consistent with Accelerated 2D Canvas flag on both implementation and chrome://gpu. Currently, we don't enable accelerated 2d canvas in software rendering mode, but chrome://gpu does not concern software rendering mode. This CL adds GPUInfo::SupportsAccelerated2dCanvas() so that any clients query if accelerated 2d canvas is supported. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238347

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M content/browser/gpu/compositor_util.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
dshwang
7 years ago (2013-11-28 15:09:12 UTC) #1
piman
lgtm
7 years ago (2013-12-03 01:09:48 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/95013004/diff/20001/gpu/config/gpu_info.h File gpu/config/gpu_info.h (right): https://codereview.chromium.org/95013004/diff/20001/gpu/config/gpu_info.h#newcode47 gpu/config/gpu_info.h:47: bool SupportsAccelerated2dCanvas() const { Does it violate coding style ...
7 years ago (2013-12-03 02:57:14 UTC) #3
piman
On Mon, Dec 2, 2013 at 6:57 PM, <zmo@chromium.org> wrote: > > https://codereview.chromium.org/95013004/diff/20001/gpu/config/gpu_info.h > File ...
7 years ago (2013-12-03 03:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/95013004/20001
7 years ago (2013-12-03 05:52:47 UTC) #5
dshwang
Thank you for review!
7 years ago (2013-12-03 05:57:36 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 11:20:32 UTC) #7
Message was sent while issue was closed.
Change committed as 238347

Powered by Google App Engine
This is Rietveld 408576698